Skip to content

Conversation

@FlorianLiers
Copy link

Hello!
It would be nice to be able to download the videos. I use this feature for slow DSL lines in order to avoid waiting for the buffering. Moreover, it is a nice feature for backing up videos removed from the mediathek too early.

Thus, I implemented a download feature comparable to the one in the YouTube plugin. The dependency to the SimpleDownloader plugin (which is doing the work) is optional. The code informs the user if it is not installed. The changes have been tested in XBMC 12.2 (German) on Windows and Linux. More details are given in cfc650a.

Since the new feature seems to be useful for others as well, I send you this pull request. Just send me a short message, if further changes are required. Best regards, Florian

FlorianLiers and others added 11 commits January 13, 2014 21:15
This commit adds a context menu entry for downloading video streams to a
folder specified in the plug-in configuration. It was inspired by the
YouTube plug-in (http://wiki.xbmc.org/index.php?title=Add-on:YouTube),
which uses the SimpleDownloader plug-in
(http://wiki.xbmc.org/index.php?title=Add-on:Simple_Downloader_for_xbmc_plugins)
for downloading video streams.

The new dependency to the SimpleDownloader is an optional one. The code
reports an error to the user, if the dependency is not
installed/activated.

Translations for the new menu entries are given in German and English.

Changes tested with XBMC 12.2 on Windows and Linux.
To fix some of the parsing bugs like in AddonScriptorDE#2, a single parsing function
for determining the attributes of a video would be easier. Thus, this
changes move all the parsing from the "list*" methods to an
"iterateContent" (parsing list of content elements) and
"extractVideoDescription" (attributes of a single content element).
Very long error messages (e.g., content of whole web page) are not
corretly displayed in XMBC 12.2. Anyhow, no user wants to read them.
Thus, it just displays a short message of the URL of the faulty web
page.
@AddonScriptorDE
Copy link
Owner

I totally agree, I also use a download feature myself.
But i won't add it to the public versions of ARD, ZDF, ARTE, ... because of legal issues.
There were some apps in the apple appstore which supported downloading, but they all got removed because of that...

Disabled by default due to unclear legal issues. See discussion in AddonScriptorDE#1.
@FlorianLiers
Copy link
Author

Do you have some links to these banned apps? There seems to be a lot of software around for downloading (e.g., http://sourceforge.net/projects/zdfmediathk/). Actually, the ARD Mediathek allows the download of some videos explicitly: http://www.ardmediathek.de/hilfe (item 8 and 9). An example for a downloadable video (even via the web interface) is the Tagesschau (e.g., http://www.ardmediathek.de/das-erste/tagesschau/tagesschau-12-00-uhr?documentId=19279708).
I propose to include the download feature in the code but to deactivate it by default. Thus, a user that is sure about the legal aspect can activate it. This would reduce the amount of work multiple users invest in implementing the same feature multiple times. I have seen that there is even another fork (fkz@e74b686) for the very same feature. I added the configuration flag in the previous comit.
What do you think? Would that be a compromise for accepting the pull request?

@AddonScriptorDE
Copy link
Owner

No, I dont have any links to these banned apps. It was mentioned somewhere on the ard website when I wrote the addon. Maybe I'll add a download solution for these downloadable videos, but not for all. Just like on the website. I only added a download function to my reddit and dailymotion addon, but I won't add it to my tv media library addons, sorry. I think it would also make no change if it could be activated or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants