Skip to content

Add YDropdownOffset Prop #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ErNeRooo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add YDropdownOffset Prop #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ const countries = ["Egypt", "Canada", "Australia", "Ireland"]

- [`showsVerticalScrollIndicator`](#showsVerticalScrollIndicator)

- [`YDropdownOffset`](#YDropdownOffset)

- [`rowStyle`](#rowStyle)

- [`rowTextStyle`](#rowTextStyle)
Expand Down Expand Up @@ -361,6 +363,16 @@ When true, shows a vertical scroll indicator.

---

### YDropdownOffset

Offset between button and dropdown view on Y axis

| Type | Required |
| ------- | -------- |
| integer | no |

---

### rowStyle

style object for row
Expand Down
3 changes: 2 additions & 1 deletion src/SelectDropdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ const SelectDropdown = (
dropdownStyle,
dropdownOverlayColor /* string */,
showsVerticalScrollIndicator,
YDropdownOffset /* integer */,
/////////////////////////////
rowStyle /* style object for row */,
rowTextStyle /* style object for row text */,
Expand Down Expand Up @@ -77,7 +78,7 @@ const SelectDropdown = (
getItemLayout,
dropdownWindowStyle,
onRequestClose,
} = useLayoutDropdown(data, dropdownStyle, rowStyle, search);
} = useLayoutDropdown(data, dropdownStyle, rowStyle, search, YDropdownOffset);
useImperativeHandle(ref, () => ({
reset: () => {
reset();
Expand Down
6 changes: 3 additions & 3 deletions src/hooks/useLayoutDropdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {calculateDropdownHeight} from '../helpers/calculateDropdownHeight';
import {useKeyboardRemainingScreenHeight} from './useKeyboardRemainingScreenHeight';
const {height} = Dimensions.get('window');

export const useLayoutDropdown = (data, dropdownStyle, rowStyle, search) => {
export const useLayoutDropdown = (data, dropdownStyle, rowStyle, search, YDropdownOffset) => {
const [isVisible, setIsVisible] = useState(false); // dropdown visible ?
const [buttonLayout, setButtonLayout] = useState(null);
const [dropdownPX, setDropdownPX] = useState(0); // position x
Expand Down Expand Up @@ -40,9 +40,9 @@ export const useLayoutDropdown = (data, dropdownStyle, rowStyle, search) => {

const dropdownWindowStyle = useMemo(() => {
const top =
remainigHeightAvoidKeyboard < dropdownPY + safeDropdownViewUnderKeyboard
remainigHeightAvoidKeyboard < dropdownPY + safeDropdownViewUnderKeyboard + YDropdownOffset
? remainigHeightAvoidKeyboard - safeDropdownViewUnderKeyboard
: dropdownPY;
: dropdownPY + YDropdownOffset;
return {
...{
borderTopWidth: 0,
Expand Down