Skip to content

Better render performance (findIndexInArr) #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yurisanp wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Better render performance (findIndexInArr) #212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/SelectDropdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, {forwardRef, useImperativeHandle, useCallback} from 'react';
import React, {forwardRef, useImperativeHandle, useCallback, useMemo} from 'react';
import {View, TouchableOpacity, FlatList} from 'react-native';
import {isExist} from './helpers/isExist';
import Input from './components/Input';
Expand Down Expand Up @@ -76,6 +76,9 @@ const SelectDropdown = (
selectItem(index);
},
}));

const selectedIndex = useMemo(() => findIndexInArr(selectedItem, dataArr), [selectedItem, dataArr]);

/* ******************* Methods ******************* */
const openDropdown = () => {
dropdownButtonRef.current.measure((fx, fy, w, h, px, py) => {
Expand All @@ -91,7 +94,7 @@ const SelectDropdown = (
onBlur && onBlur();
};
const scrollToSelectedItem = () => {
const indexInCurrArr = findIndexInArr(selectedItem, dataArr);
const indexInCurrArr = selectedIndex;
setTimeout(() => {
if (disableAutoScroll) {
return;
Expand Down Expand Up @@ -144,8 +147,7 @@ const SelectDropdown = (
);
};
const renderFlatlistItem = ({item, index}) => {
const indexInCurrArr = findIndexInArr(selectedItem, dataArr);
const isSelected = index == indexInCurrArr;
const isSelected = index == selectedIndex;

let clonedElement = renderItem ? renderItem(item, index, isSelected) : <View />;
let props = {...clonedElement.props};
Expand Down