Skip to content

Conversation

@erikmarr
Copy link
Contributor

@erikmarr erikmarr commented Jan 13, 2026

Pull request overview

This pull request removes documentation about a GraphQL warning message that is included when an empty or invalid categoryPath or categoryIDs field is passed with position sorting. The documentation now focuses on the behavior itself rather than the warning response. https://jira.corp.adobe.com/browse/MSRCH-5337

Changes:

  • Removed detailed warning message documentation including JSON example
  • Updated text to reflect that queries execute successfully without mentioning warnings
  • Simplified example query description

This PR effectively reverts part of this closed PR: #519

Affected pages

Copilot AI review requested due to automatic review settings January 13, 2026 18:40
@github-project-automation github-project-automation bot moved this to 📋 Needs Review in Commerce - Pull Requests Jan 13, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes documentation about a GraphQL warning message that is included when an empty or invalid categoryPath or categoryIDs field is passed with position sorting. The documentation now focuses on the behavior itself rather than the warning response.

Changes:

  • Removed detailed warning message documentation including JSON example
  • Updated text to reflect that queries execute successfully without mentioning warnings
  • Simplified example query description

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@erikmarr erikmarr requested a review from kiranv926 January 13, 2026 19:35
@kiranv926
Copy link

+1 , Looks good to me.

@github-project-automation github-project-automation bot moved this from 📋 Needs Review to 👍 Approved in Commerce - Pull Requests Jan 13, 2026
@erikmarr erikmarr merged commit a2d973b into main Jan 13, 2026
25 checks passed
@erikmarr erikmarr deleted the em_revert-catpathwarn branch January 13, 2026 19:52
@github-project-automation github-project-automation bot moved this from 👍 Approved to 🏁 Done in Commerce - Pull Requests Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🏁 Done

Development

Successfully merging this pull request may close these issues.

4 participants