Add support for ag grid 27.3.0 blank/notblank filter options#3
Open
AutoGibbon wants to merge 1 commit intoAdrianWilczynski:masterfrom
Open
Add support for ag grid 27.3.0 blank/notblank filter options#3AutoGibbon wants to merge 1 commit intoAdrianWilczynski:masterfrom
AutoGibbon wants to merge 1 commit intoAdrianWilczynski:masterfrom
Conversation
Owner
|
Hi, I didn't have a chance to test it yet, but I wonder if it shouldn't also check for empty/whitespace strings. |
Author
|
To do that reliably you'd need to inspect the underlying type for the given property name in GetPredicate, since the blank filters can be applied to more than just strings. I can take a look into this when I get some time - we have a hack in our project for now, replacing blank/notblank for the existing null/notnull filter types in a custom modelbinder. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for blank/notBlank filter options present in ag-grid v27.3.0
Merges behaviour with existing not/notnull options