Skip to content

Conversation

@jeandersonbc
Copy link
Contributor

Description

Added comprehensive RSpec test suite for Adyen::Capital services (GrantAccountsApi, GrantOffersApi, GrantsApi).
Integrated the Capital API into the main client by:

  • Exposing Adyen::Capital via the client.capital accessor.
  • Configuring the service URL (balanceplatform-api) in Adyen::Client#service_url_base.
  • Requiring the adyen/services/capital module in adyen-ruby-api-library.rb.

Tested scenarios

Created necessary JSON mock response fixtures under spec/mocks/responses/Capital to facilitate isolated testing. Tests cover all primary API endpoints for retrieving grant accounts, offers, and grants, as well as making grant requests and managing disbursements, ensuring functionality and correct integration.

Fixed issue:

  • N/A

@jeandersonbc jeandersonbc self-assigned this Jan 21, 2026
@jeandersonbc jeandersonbc requested review from a team as code owners January 21, 2026 15:40
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jeandersonbc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the Adyen Ruby API library by introducing full support for the Capital API. It enables users to programmatically interact with Capital services, such as managing grant accounts, offers, and grants, through a well-defined client interface. The integration is backed by a comprehensive set of RSpec tests and mock responses, ensuring reliability and ease of use for developers.

Highlights

  • Capital API Integration: The Adyen Capital API has been fully integrated into the client library, exposing services like GrantAccountsApi, GrantOffersApi, and GrantsApi via the client.capital accessor.
  • Service URL Configuration: The base URL for the Capital API (balanceplatform-api) is now correctly configured within the client's service URL resolution logic.
  • Comprehensive Test Coverage: A new RSpec test suite (spec/capital_spec.rb) has been added, covering all primary API endpoints for Capital services, including retrieving accounts, offers, grants, making requests, and managing disbursements.
  • Mock Response Fixtures: Dedicated JSON mock response fixtures have been created under spec/mocks/responses/Capital to facilitate robust and isolated testing of the Capital API interactions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively integrates the Adyen Capital API into the client and adds a comprehensive RSpec test suite to ensure its functionality. The implementation is clean and follows the existing patterns in the codebase. My review includes several suggestions for the new test files, focusing on improving maintainability by adhering to RSpec best practices, enhancing code style, and fixing minor formatting issues in the mock JSON responses. Overall, this is a solid contribution.

Added comprehensive RSpec test suite for `Adyen::Capital` services (`GrantAccountsApi`,
`GrantOffersApi`, `GrantsApi`).

Integrated the Capital API into the main client by:
- Exposing `Adyen::Capital` via the `client.capital` accessor.
- Configuring the service URL (`balanceplatform-api`) in `Adyen::Client#service_url_base`.
- Requiring the `adyen/services/capital` module in `adyen-ruby-api-library.rb`.

Created necessary JSON mock response fixtures under `spec/mocks/responses/Capital` to
facilitate isolated testing. Tests cover all primary API endpoints for retrieving grant
accounts, offers, and grants, as well as making grant requests and managing disbursements,
ensuring functionality and correct integration.
@jeandersonbc jeandersonbc force-pushed the feat-capital-test-coverage branch from dbf9a17 to 3d028aa Compare January 23, 2026 09:11
@sonarqubecloud
Copy link

@jeandersonbc
Copy link
Contributor Author

removed the label since this PR is test-related.

@jeandersonbc jeandersonbc merged commit a794a9e into main Jan 23, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants