Use DisposableStack for resource cleanup#98
Merged
shgysk8zer0 merged 1 commit intomasterfrom Feb 27, 2026
Merged
Conversation
Introduce DisposableStack-based lifecycle management for the barcode scanner: createBarcodeScanner now accepts a `base` (DocumentOrShadowRoot) to find video elements by id and an optional `stack` to manage disposables. Internals now adopt/defer abort controllers, wake lock and media stream via a DisposableStack/AsyncDisposableStack, attach stack disposal on abort, and surface a disposable on the returned scanner object. index.js `start()` was converted to async and updated to use a DisposableStack for start/stop handling. CHANGELOG updated and package.json version bumped to 1.2.3 with dev dependency version bumps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce DisposableStack-based lifecycle management for the barcode scanner: createBarcodeScanner now accepts a
base(DocumentOrShadowRoot) to find video elements by id and an optionalstackto manage disposables. Internals now adopt/defer abort controllers, wake lock and media stream via a DisposableStack/AsyncDisposableStack, attach stack disposal on abort, and surface a disposable on the returned scanner object. index.jsstart()was converted to async and updated to use a DisposableStack for start/stop handling. CHANGELOG updated and package.json version bumped to 1.2.3 with dev dependency version bumps.Description and issue
List of significant changes made