Conversation
ruilvo
left a comment
ruilvo
left a comment
There was a problem hiding this comment.
I have a couple comments, see them.
Also, I would like more if this was inside maybe scripts/buildroot, not just builldroot/, for project organization reasons. Other than that, I like it.
| -DBUILD_DOC=OFF \ | ||
| -DBUILD_DOCS=OFF \ | ||
| -DBUILD_EXAMPLE=OFF \ | ||
| -DBUILD_EXAMPLES=OFF \ | ||
| -DBUILD_TEST=OFF \ | ||
| -DBUILD_TESTS=OFF \ | ||
| -DBUILD_TESTING=OFF \ | ||
| -DBUILD_SHARED_LIBS=ON \ | ||
| -DBUILD_SHARED_LIB=ON |
There was a problem hiding this comment.
Why the lines with S and without S? Only with S is correct.
There was a problem hiding this comment.
Why the lines with S and without S? Only with S is correct.
This is exactly what buildroot does when it works. Just copy-paste
Also, I would like more if this was inside maybe scripts/buildroot, not just builldroot/, for project organization reasons. Other than that, I like it.
I don't think there will be any more scripts in this project. I don't see the need for this. So there is no point in making a subdirectory
| ./cmake.sh | ||
| make | ||
| ./install.sh | ||
| ``` |
There was a problem hiding this comment.
It would be nice to say where the project needs to be pasted relative to the Buildroot directory? Just inside it?
There was a problem hiding this comment.
Especially because the conf.sh file hardcodes this.
2 participants
No description provided.