Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions swe_af/execution/coding_loop.py
Original file line number Diff line number Diff line change
Expand Up @@ -699,6 +699,12 @@ async def run_coding_loop(

# --- 4. BRANCH ON ACTION ---
if action == "approve":
if iteration == 1:
if note_fn:
note_fn(
f"FAST-PATH EXIT: {issue_name} approved on first iteration",
tags=["coding_loop", "fast_path", "complete", issue_name],
)
if note_fn:
note_fn(
f"Coding loop APPROVED: {issue_name} after {iteration} iteration(s)",
Expand Down
3 changes: 3 additions & 0 deletions swe_af/execution/schemas.py
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,9 @@ class QASynthesisResult(BaseModel):
"claude_code": {
**{field: "sonnet" for field in ALL_MODEL_FIELDS},
"qa_synthesizer_model": "haiku",
"retry_advisor_model": "haiku",
"git_model": "haiku",
"merger_model": "haiku",
},
"open_code": {
**{field: "minimax/minimax-m2.5" for field in ALL_MODEL_FIELDS},
Expand Down
34 changes: 17 additions & 17 deletions swe_af/reasoners/execution_agents.py
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ async def run_retry_advisor(
model=model,
provider=ai_provider,
cwd=repo_path,
max_turns=DEFAULT_AGENT_MAX_TURNS,
max_turns=20,
allowed_tools=[Tool.READ, Tool.GLOB, Tool.GREP, Tool.BASH],
permission_mode=permission_mode or None,
))
Expand Down Expand Up @@ -215,7 +215,7 @@ async def run_issue_advisor(
model=model,
provider=ai_provider,
cwd=cwd,
max_turns=DEFAULT_AGENT_MAX_TURNS,
max_turns=30,
allowed_tools=[Tool.READ, Tool.GLOB, Tool.GREP, Tool.BASH],
permission_mode=permission_mode or None,
))
Expand Down Expand Up @@ -293,7 +293,7 @@ async def run_replanner(
model=replan_model,
provider=ai_provider,
cwd=state.repo_path or ".",
max_turns=DEFAULT_AGENT_MAX_TURNS,
max_turns=30,
allowed_tools=[Tool.READ, Tool.GLOB, Tool.GREP, Tool.BASH],
permission_mode=permission_mode or None,
))
Expand Down Expand Up @@ -407,7 +407,7 @@ class IssueWriterOutput(BaseModel):
model=model,
provider=ai_provider,
cwd=repo_path,
max_turns=DEFAULT_AGENT_MAX_TURNS,
max_turns=20,
allowed_tools=[Tool.READ, Tool.WRITE, Tool.GLOB, Tool.GREP],
permission_mode=permission_mode or None,
))
Expand Down Expand Up @@ -472,7 +472,7 @@ async def run_verifier(
model=model,
provider=ai_provider,
cwd=repo_path,
max_turns=DEFAULT_AGENT_MAX_TURNS,
max_turns=30,
allowed_tools=[Tool.READ, Tool.GLOB, Tool.GREP, Tool.BASH],
permission_mode=permission_mode or None,
))
Expand Down Expand Up @@ -558,7 +558,7 @@ async def run_git_init(
model=model,
provider=ai_provider,
cwd=repo_path,
max_turns=DEFAULT_AGENT_MAX_TURNS,
max_turns=10,
allowed_tools=[Tool.BASH],
permission_mode=permission_mode or None,
))
Expand Down Expand Up @@ -636,7 +636,7 @@ class WorkspaceSetupResult(BaseModel):
model=model,
provider=ai_provider,
cwd=repo_path,
max_turns=DEFAULT_AGENT_MAX_TURNS,
max_turns=10,
allowed_tools=[Tool.BASH],
permission_mode=permission_mode or None,
))
Expand Down Expand Up @@ -703,7 +703,7 @@ async def run_merger(
model=model,
provider=ai_provider,
cwd=repo_path,
max_turns=DEFAULT_AGENT_MAX_TURNS,
max_turns=10,
allowed_tools=[Tool.BASH, Tool.READ, Tool.GLOB, Tool.GREP],
permission_mode=permission_mode or None,
))
Expand Down Expand Up @@ -777,7 +777,7 @@ async def run_integration_tester(
model=model,
provider=ai_provider,
cwd=repo_path,
max_turns=DEFAULT_AGENT_MAX_TURNS,
max_turns=30,
allowed_tools=[Tool.BASH, Tool.READ, Tool.WRITE, Tool.GLOB, Tool.GREP],
permission_mode=permission_mode or None,
))
Expand Down Expand Up @@ -848,7 +848,7 @@ class WorkspaceCleanupResult(BaseModel):
model=model,
provider=ai_provider,
cwd=repo_path,
max_turns=DEFAULT_AGENT_MAX_TURNS,
max_turns=10,
allowed_tools=[Tool.BASH],
permission_mode=permission_mode or None,
))
Expand Down Expand Up @@ -922,7 +922,7 @@ async def run_coder(
model=model,
provider=ai_provider,
cwd=worktree_path,
max_turns=DEFAULT_AGENT_MAX_TURNS,
max_turns=50,
allowed_tools=[
Tool.READ, Tool.WRITE, Tool.EDIT,
Tool.BASH, Tool.GLOB, Tool.GREP,
Expand Down Expand Up @@ -999,7 +999,7 @@ async def run_qa(
model=model,
provider=ai_provider,
cwd=worktree_path,
max_turns=DEFAULT_AGENT_MAX_TURNS,
max_turns=20,
allowed_tools=[
Tool.READ, Tool.WRITE, Tool.EDIT,
Tool.BASH, Tool.GLOB, Tool.GREP,
Expand Down Expand Up @@ -1079,7 +1079,7 @@ async def run_code_reviewer(
model=model,
provider=ai_provider,
cwd=worktree_path,
max_turns=DEFAULT_AGENT_MAX_TURNS,
max_turns=20,
allowed_tools=[Tool.READ, Tool.GLOB, Tool.GREP, Tool.BASH],
permission_mode=permission_mode or None,
))
Expand Down Expand Up @@ -1155,7 +1155,7 @@ async def run_qa_synthesizer(
model=model,
provider=ai_provider,
cwd=worktree_path or ".",
max_turns=DEFAULT_AGENT_MAX_TURNS,
max_turns=10,
allowed_tools=[],
permission_mode=permission_mode or None,
))
Expand Down Expand Up @@ -1251,7 +1251,7 @@ class FixGeneratorOutput(BaseModel):
model=model,
provider=ai_provider,
cwd=repo_path,
max_turns=DEFAULT_AGENT_MAX_TURNS,
max_turns=30,
allowed_tools=[Tool.READ, Tool.GLOB, Tool.GREP, Tool.BASH],
permission_mode=permission_mode or None,
))
Expand Down Expand Up @@ -1320,7 +1320,7 @@ async def run_repo_finalize(
model=model,
provider=ai_provider,
cwd=repo_path,
max_turns=DEFAULT_AGENT_MAX_TURNS,
max_turns=10,
allowed_tools=[Tool.BASH, Tool.READ, Tool.GLOB, Tool.GREP],
permission_mode=permission_mode or None,
))
Expand Down Expand Up @@ -1396,7 +1396,7 @@ async def run_github_pr(
model=model,
provider=ai_provider,
cwd=repo_path,
max_turns=DEFAULT_AGENT_MAX_TURNS,
max_turns=10,
allowed_tools=[Tool.BASH],
permission_mode=permission_mode or None,
))
Expand Down
8 changes: 4 additions & 4 deletions swe_af/reasoners/pipeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ async def run_product_manager(
artifacts_dir: str = ".artifacts",
additional_context: str = "",
model: str = "sonnet",
max_turns: int = DEFAULT_AGENT_MAX_TURNS,
max_turns: int = 30,
permission_mode: str = "",
ai_provider: str = "claude",
) -> dict:
Expand Down Expand Up @@ -212,7 +212,7 @@ async def run_architect(
artifacts_dir: str = ".artifacts",
feedback: str = "",
model: str = "sonnet",
max_turns: int = DEFAULT_AGENT_MAX_TURNS,
max_turns: int = 30,
permission_mode: str = "",
ai_provider: str = "claude",
) -> dict:
Expand Down Expand Up @@ -260,7 +260,7 @@ async def run_tech_lead(
artifacts_dir: str = ".artifacts",
revision_number: int = 0,
model: str = "sonnet",
max_turns: int = DEFAULT_AGENT_MAX_TURNS,
max_turns: int = 30,
permission_mode: str = "",
ai_provider: str = "claude",
) -> dict:
Expand Down Expand Up @@ -310,7 +310,7 @@ async def run_sprint_planner(
repo_path: str,
artifacts_dir: str = ".artifacts",
model: str = "sonnet",
max_turns: int = DEFAULT_AGENT_MAX_TURNS,
max_turns: int = 30,
permission_mode: str = "",
ai_provider: str = "claude",
) -> dict:
Expand Down
9 changes: 5 additions & 4 deletions tests/test_model_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,12 @@
class TestResolveRuntimeModels(unittest.TestCase):
def test_claude_code_defaults(self) -> None:
resolved = resolve_runtime_models(runtime="claude_code", models=None)
haiku_fields = {"qa_synthesizer_model", "retry_advisor_model", "git_model", "merger_model"}
for field in ALL_MODEL_FIELDS:
if field == "qa_synthesizer_model":
continue
self.assertEqual(resolved[field], "sonnet")
self.assertEqual(resolved["qa_synthesizer_model"], "haiku")
if field in haiku_fields:
self.assertEqual(resolved[field], "haiku")
else:
self.assertEqual(resolved[field], "sonnet")

def test_open_code_defaults(self) -> None:
resolved = resolve_runtime_models(runtime="open_code", models=None)
Expand Down
Loading