Skip to content

Chore single check workflow#34

Merged
Agent-Hellboy merged 4 commits intomainfrom
chore-single-check-workflow
Jan 31, 2026
Merged

Chore single check workflow#34
Agent-Hellboy merged 4 commits intomainfrom
chore-single-check-workflow

Conversation

@Agent-Hellboy
Copy link
Owner

@Agent-Hellboy Agent-Hellboy commented Jan 31, 2026

Summary by CodeRabbit

  • Chores
    • Enhanced CI workflow to run on push events to main branch in addition to pull requests.
    • Removed separate post-merge checks workflow.
    • Updated Docker base image for E2E testing environment.
    • Added build-unix Makefile target.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 31, 2026

📝 Walkthrough

Walkthrough

The pull request consolidates CI workflows by renaming "Pre-Check" to "CI" with extended triggers on main branch pushes, removes the separate post-merge workflow file, adds a build-unix Makefile alias, updates the README status badge, and changes the E2E Docker base image from distro-specific to generic.

Changes

Cohort / File(s) Summary
CI Workflow Consolidation
.github/workflows/ci.yaml, .github/workflows/post-merge.yaml
Renamed CI workflow with added push triggers on main branch; removed post-merge workflow entirely (117 lines deleted), consolidating multi-job flow into single CI definition.
Build Tooling
Makefile
Added build-unix target as a public Makefile alias for build-all to maintain stable CI target naming conventions.
Documentation & Configuration
README.md, test/e2e/Dockerfile
Updated status badge from Post-Merge Checks to CI; changed E2E Docker base image from golang:1.24.11-bullseye to golang:1.24.11 (removing distro-specific tag).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 Workflows unified with care,
Old post-merge workflows stripped bare,
CI now runs on every push,
Build targets stable, no rush,
Docker image cleaned, fresh and bright! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Chore single check workflow' accurately describes the main change: consolidating multiple CI workflows into a single unified CI workflow by removing the post-merge workflow and updating the CI configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore-single-check-workflow

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Jan 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.54%. Comparing base (f62b811) to head (90cdd3e).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage   77.54%   77.54%           
=======================================
  Files          28       28           
  Lines        3758     3758           
=======================================
  Hits         2914     2914           
  Misses        686      686           
  Partials      158      158           
Flag Coverage Δ
post-merge ?
pre-merge 77.54% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
test/e2e/Dockerfile (1)

16-19: ⚠️ Potential issue | 🟡 Minor

Architecture mismatch: kubectl and kind are hardcoded to amd64.

Lines 11-12 correctly detect architecture for Docker CLI, but kubectl and kind downloads are hardcoded to linux/amd64. This will fail on ARM64 hosts.

🔧 Proposed fix to support multi-architecture
-    curl -fsSLo /usr/local/bin/kubectl https://storage.googleapis.com/kubernetes-release/release/v1.27.3/bin/linux/amd64/kubectl && \
+    KUBE_ARCH="$(dpkg --print-architecture)" && \
+    curl -fsSLo /usr/local/bin/kubectl "https://storage.googleapis.com/kubernetes-release/release/v1.27.3/bin/linux/${KUBE_ARCH}/kubectl" && \
     chmod +x /usr/local/bin/kubectl && \
-    curl -fsSLo /usr/local/bin/kind https://kind.sigs.k8s.io/dl/v0.20.0/kind-linux-amd64 && \
+    curl -fsSLo /usr/local/bin/kind "https://kind.sigs.k8s.io/dl/v0.20.0/kind-linux-${KUBE_ARCH}" && \
     chmod +x /usr/local/bin/kind
🧹 Nitpick comments (1)
.github/workflows/ci.yaml (1)

83-83: Consider updating the coverage flag name.

The flags: pre-merge label may be misleading now that this workflow also runs on pushes to main (post-merge). Consider renaming to something like ci or removing the flag distinction if you're no longer tracking pre-merge vs post-merge coverage separately.

@Agent-Hellboy Agent-Hellboy merged commit 2ae672e into main Jan 31, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant