Open
Conversation
The segfault behavior that this patch intends to fix might be fixed upstream. Track issue on remote github: BelledonneCommunications/linphone-sdk#183
hedvigkamp
force-pushed
the
yocto-dunfell
branch
from
e00ae05 to
699c4cc
Compare
hedvigkamp
changed the base branch from
yocto-dunfell
to
test-rebased-yocto-dunfell
hedvigkamp
changed the base branch from
test-rebased-yocto-dunfell
to
original-dunfell
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies patches to linphone-daemon cli command "call-stats". The upstream implementation appears to naively expect each call to have both an audio and video component. When linphone performs a lookup for the video component this returns a nullptr (since our calls only use an audio component).
This nullptr is then passed to the ctor for CallStatsEvent where it is eventually dereferenced in subsequent calls causing a segfault.
This PR pushes two patches - the first one only comments out the code and the second one is a little bit more intricate where an explicit nullcheck is performed instead.
An issue has been created in the upstream repo for tracking:
BelledonneCommunications/linphone-sdk#183