Skip to content

Test rebased yocto dunfell#2

Open
hedvigkamp wants to merge 13 commits intoyocto-dunfell-upstreamfrom
test-rebased-yocto-dunfell
Open

Test rebased yocto dunfell#2
hedvigkamp wants to merge 13 commits intoyocto-dunfell-upstreamfrom
test-rebased-yocto-dunfell

Conversation

@hedvigkamp
Copy link

I created a test branch to test the rebased version of yocto-dunfell before pushing it.

Linus Wallgren and others added 10 commits October 20, 2021 13:31
No changes seems to be needed after going through the migration steps

https://docs.yoctoproject.org/ref-manual/migration-2.6.html
No changes from the migration guide seemed to be relevant

https://docs.yoctoproject.org/ref-manual/migration-2.7.html
This release removes support for lsb. Otherwise no changes seems to
affect this layer

https://docs.yoctoproject.org/ref-manual/migration-3.0.html
This commit mainly exist to clearly mark the patch applied to it for the
future. So basically if you are trying to port this patch to a newer
version, check the subsequent commits to this file.
This ports the patch introduced in
e27c739 onto the dunfell version of
cmake.bbclass
 * linphone-sdk.bb has been removed upstream so this new file is added
   to keep information about what commit was used for version 4.4
python2 is no longer supported by dunfell
@hedvigkamp hedvigkamp requested a review from ecksun October 21, 2021 11:23
@ecksun
Copy link

ecksun commented Oct 21, 2021

Alright, comments:

  • Add mariadb that was lost along the way - mariadb was lost in "Switch to sqlite3 per default", so that was on purpose
  • Set release branch 5.0 explicitely for linphone-sdk - We can probably set the LINPHONE_SDK_BRANCH in a bbappend file or something
  • Enable console_ui - Should not go into this PR but that commit isn't needed, I have tested it twice now
  • Upgrade to linphone 5 - This disables LDAP but there is already a commit ("Deactivate OpenLDAP") that does that?
  • Migrate to use python3 instead of python2 - This is already done in "Move python dependency from version 2 to 3". I guess the only diff in there would be solved by the .bb file specifying VERSION_DEPENDENT_DEPENDS ?
  • cmakebuilder: apply patch from meta-bc - I'm not sure why this is needed, but the patch looks the same as when I originally did it so I guess it is okay?

I think the correct way of having linphone 5.0 is to define our own linphone-sdk-5.0.x.bb. I think it will look similar to the linphone_sdk_4.4.x.bb file

@hedvigkamp hedvigkamp force-pushed the test-rebased-yocto-dunfell branch from 0e4cbac to 8a17a34 Compare October 22, 2021 07:43
 * Upgrade linphone-sdk to version 5
 * This required disabling LDAP and enabling the DAEMON

 Due to rebasing on upstream yocto-sumo where linphone-sdk.bb had been
 removed, it was required to add linphone-sdk_5.0.x.bb to upgrade to
 linphone version 5.
@hedvigkamp hedvigkamp force-pushed the test-rebased-yocto-dunfell branch from 8a17a34 to 2b8868f Compare October 22, 2021 08:36
@hedvigkamp hedvigkamp changed the base branch from yocto-dunfell to yocto-dunfell-upstream October 22, 2021 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants