Skip to content

Add Rotary Encoder Driver to 4.6.3#17

Open
anant3110 wants to merge 147 commits intoairbound-develop-4.6from
pr-add-rotary-encoder-4.6
Open

Add Rotary Encoder Driver to 4.6.3#17
anant3110 wants to merge 147 commits intoairbound-develop-4.6from
pr-add-rotary-encoder-4.6

Conversation

@anant3110
Copy link

Migrate the rotary encoder driver from 4.5.7 to 4.6.2

tridge and others added 30 commits August 5, 2025 10:05
top level parameters don't have flags, but we need to fill in the
flags return field as otherwise we can refuse to set a parameter based
on it being internal and the allow_set_via_mavlink() check
Let's fix the GitHub Action workflow macos_build that is failing consistently.

* https://github.com/ArduPilot/ardupilot/actions/workflows/macos_build.yml

Upgrade pyenv and Python 3.10 in Tools/environment_install/install-prereqs-mac.sh

Questions:
* Why install and configure pyenv by hand instead of doing `brew install pyenv`?
* Why specify the micro version Python 3.10.4 instead of 3.10?
* Why not use `brew install uv && uv python install 3.10` instead of pyenv?
They have been past end of support for nearly one year and nearly two
years respectively. Allows us to require at minimum Python 3.8.
this gives greater control of when the rangefinder will be used. A
particularly important one is the ability to disable it for VTOL
assist as false positives can be quite common and drains the battery
when ICE motors are running (and they are commonly started before
arming) the IMU noise can overwhelm the IMU consistency checks,
preventing arming. This gives the user a way to disable that check
instead set a range and retrieve value from configured range with zero dz
Co-authored-by: Henry Wurzburg <hwurzburg@yahoo.com>
Co-authored-by: Henry Wurzburg <hwurzburg@yahoo.com>
commit f64add0
Author: ThenYang <engineer@dakefpv.com>
Date:   Thu Jul 10 17:13:57 2025 +0800

    lower the resolution of the images so that they are not so large

commit 2352cd5
Author: ThenYang <engineer@dakefpv.com>
Date:   Thu Jul 10 14:29:59 2025 +0800

    The DAKEFPVH743 is based on the DAKEFPVH743Pro.

commit f51ac2d
Author: 玄绮 <shijiahansi@qq.com>
Date:   Thu Jul 10 14:29:59 2025 +0800

    Update DAKEFPVH743PRO

commit be7b6fb
Author: 玄绮 <engineer@dakefpv.com>
Date:   Thu Jul 10 14:29:59 2025 +0800

    update:
    hwdef.dat:
    1.UART5 use DMA for RCIN.
    2.USART2,3 NODMA.
    3.USART6,7 use DMA.

    defaults.parm:
    1.setup for LEDs on chan14.

    WiringDiagramTop.png:
    1.updated the correct wiring diagram.

commit f249d5e
Author: 玄绮 <engineer@dakefpv.com>
Date:   Thu Jul 10 14:29:58 2025 +0800

    BATT_VOLT_MULT default 16.0

commit e24d940
Author: 玄绮 <engineer@dakefpv.com>
Date:   Thu Jul 10 14:29:58 2025 +0800

    Add New Target DAKEFPVH743
Reserve range IDs 7120-7129 for Accton Godwit.
And add id 7120 for Accton-Godwit GA1
AJ and others added 15 commits October 13, 2025 08:19
extend with more data fields, and fixes for time sync control from
JSON server
pyrobolearn is not maintained any more and does not work with recent
python versions
same option bit was being used in both cases
Fixed a bug where the landing slope recalculation logic based on
rangefinder data could run as long as there was a rangefinder fitted,
despite it not being currently in use, or even enabled for landing at
all.

This could lead to sharp altitude demand adjustments, often right before
flare in the case of short range rangefinders. Thanks to Henry Wurzburg
for discovering this.
@anant3110 anant3110 requested a review from botmayank October 23, 2025 08:45
@anant3110 anant3110 force-pushed the pr-add-rotary-encoder-4.6 branch from 913e220 to ae7e1b2 Compare November 27, 2025 08:54
@coderabbitai
Copy link

coderabbitai bot commented Nov 27, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch pr-add-rotary-encoder-4.6

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@anant3110 anant3110 changed the title Add Rotary Encoder Driver to 4.6.2 Add Rotary Encoder Driver to 4.6.3 Nov 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.