Skip to content

RPM based thrust vectoring servo input scaling (Pitch control effort scaling)#28

Merged
botmayank merged 33 commits intoairbound-developfrom
pr-decoupling_alt_atti
Feb 6, 2026
Merged

RPM based thrust vectoring servo input scaling (Pitch control effort scaling)#28
botmayank merged 33 commits intoairbound-developfrom
pr-decoupling_alt_atti

Conversation

@Manuraj-PM
Copy link

@Manuraj-PM Manuraj-PM commented Jan 5, 2026

Notion page for theoretical explanation, implementation details and log analysis:
https://www.notion.so/airbound/Decoupling-the-vertical-and-Attitude-controllers-2c321adf4be980b89fa5cae73ac286fb?source=copy_link
This pr is on top of the throttle scaling with lean angle functionality. The details is given in this page : #31

@coderabbitai
Copy link

coderabbitai bot commented Jan 5, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch pr-decoupling_alt_atti

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Manuraj-PM Manuraj-PM marked this pull request as draft January 5, 2026 06:46
@Manuraj-PM Manuraj-PM changed the title Pr decoupling alt atti RPM based thrust vectoring servo input scaling (Pitch control effort scaling) Jan 10, 2026
@Manuraj-PM Manuraj-PM force-pushed the pr-decoupling_alt_atti branch from 1e9bc3e to ba57e71 Compare January 16, 2026 07:26
Copy link
Member

@botmayank botmayank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requested changes

Copy link
Member

@botmayank botmayank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requested changes

@Manuraj-PM Manuraj-PM requested a review from botmayank January 21, 2026 07:21
Copy link
Member

@botmayank botmayank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requested minor change, rest lgtm now

@Manuraj-PM Manuraj-PM requested a review from botmayank January 21, 2026 07:26
@Manuraj-PM Manuraj-PM force-pushed the pr-decoupling_alt_atti branch 2 times, most recently from 682351e to a375834 Compare February 6, 2026 05:36
@Manuraj-PM Manuraj-PM marked this pull request as ready for review February 6, 2026 05:49
@Manuraj-PM Manuraj-PM force-pushed the pr-decoupling_alt_atti branch from 0a35f70 to 1389994 Compare February 6, 2026 07:24
@Manuraj-PM Manuraj-PM force-pushed the pr-decoupling_alt_atti branch from 5c2e268 to 4dcbf12 Compare February 6, 2026 10:51
@Manuraj-PM Manuraj-PM requested a review from botmayank February 6, 2026 10:52
Copy link
Member

@botmayank botmayank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, merging

@botmayank botmayank merged commit a095c6c into airbound-develop Feb 6, 2026
162 of 175 checks passed
@botmayank botmayank deleted the pr-decoupling_alt_atti branch February 6, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants