Conversation
* update branch in sub * add mdt to solution * update branch in sub * add mdt to solution * prototype texture verifier * improve error reporting * finish new game init reporting * start GameManagers * update subs * update sub * move to gamemanager arch * first support for gui dialogs * remove valuelistdict to xml objects to avoid boxing * fix gameobject land terrain model mapping uses only the first ocurrance * update deps and module * minor changes * fix initialization * correct file not found handling * use spans for repositories * support custom xml parser action * reduce allocations in repository * update valuestringbuilder usages * fix some files are not found. * extract constants * implement parsing commandbar components (except colors) * move code * move code * move code * remove submodule * remove module * update all deps and make run again * read corrupt string throws BinaryCorruptedExcpetion * update to .net9
There was a problem hiding this comment.
Copilot reviewed 311 out of 317 changed files in this pull request and generated 1 comment.
Files not reviewed (6)
- .gitmodules: Language not supported
- Directory.Build.props: Language not supported
- ModVerify.sln: Language not supported
- PetroglyphTools: Language not supported
- src/Directory.Build.props: Language not supported
- src/ModVerify.CliApp/ModVerify.CliApp.csproj: Language not supported
Comments suppressed due to low confidence (2)
src/ModVerify.CliApp/ModSelectors/ModSelectorBase.cs:70
- The removal of the .Select(x => x.Mod) transformation changes the type of objects processed. Please verify that this change was intentional and that it correctly handles the objects returned by the traverser.
return traverser.Traverse(mod) .OfType<IPhysicalMod>().Select(x => x.Directory.FullName)
src/ModVerify.CliApp/GameFinder/GameFinderService.cs:100
- [nitpick] Changing the log level from Trace to Information may result in more verbose logs in production. Confirm that this update to the logging level aligns with your logging strategy.
_logger?.LogInformation($"Found game installation: {result.GameIdentity} at {result.GameLocation.FullName}")
There was a problem hiding this comment.
Copilot reviewed 311 out of 317 changed files in this pull request and generated 1 comment.
Files not reviewed (6)
- .gitmodules: Language not supported
- Directory.Build.props: Language not supported
- ModVerify.sln: Language not supported
- PetroglyphTools: Language not supported
- src/Directory.Build.props: Language not supported
- src/ModVerify.CliApp/ModVerify.CliApp.csproj: Language not supported
There was a problem hiding this comment.
Copilot reviewed 311 out of 317 changed files in this pull request and generated no comments.
Files not reviewed (6)
- .gitmodules: Language not supported
- Directory.Build.props: Language not supported
- ModVerify.sln: Language not supported
- PetroglyphTools: Language not supported
- src/Directory.Build.props: Language not supported
- src/ModVerify.CliApp/ModVerify.CliApp.csproj: Language not supported
Comments suppressed due to low confidence (1)
src/ModVerify.CliApp/ModSelectors/SettingsBasedModSelector.cs:37
- The updated logic removes the previous null or empty check before returning the mod name. To maintain robust error handling, consider reintroducing validation to ensure that the returned name is neither null nor empty.
return mod ?? gameLocations.GamePath;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.