make integer division explicit#8
Open
ioannis-vm wants to merge 1 commit intoAlbanoCastroSousa:masterfrom
Open
Conversation
In python 3, j/k always returns a float. Integer division is performed using j // k, or more explicitly int(j/k). The latter syntax is already used in most files. This commit addresses that issue in the following files too: modified: RESSPyLab/solution_vis.py modified: RESSPyLab/uvc_constraints.py modified: RESSPyLab/vc_limited_info_opt.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In python 3, j/k always returns a float. Using the result in the range() function results in an error.
Integer division is performed using j // k, or more explicitly
int(j/k).
The explicit syntax is already used in most files.
This commit replaces the first syntax which doesn't work in python 3 with the explicit division, in the following files:
modified: RESSPyLab/solution_vis.py
modified: RESSPyLab/uvc_constraints.py
modified: RESSPyLab/vc_limited_info_opt.py