Add FIFA data parser support

[ouyang1030]

Support for FIFA event data

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.35%. Comparing base (e4ce2b3) to head (5ababd5).
⚠️ Report is 78 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #339      +/-   ##
===========================================
+ Coverage    99.22%   99.35%   +0.13%     
===========================================
  Files           49       66      +17     
  Lines         3736     5265    +1529     
===========================================
+ Hits          3707     5231    +1524     
- Misses          29       34       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Alek050]

Hi @ouyang1030,

Thanks for opening this PR. I am really happy with the quality and style of your code. I really appreciate that you kept a very similar format and architecture for writing the parser that is already used in DataBallPy. Before we can merge it we need a few minor and one major point.

1. Consider removing inline comments as much as possible. The code should speak for itself. I think the code by itself is clear enough, any necessary additions can be added to the docstrings instead.
2. It seems like you build in events that have NaT. Since the datetime objects are used in synchronisation I would like your thoughts on a fallback date option. For example if a game has now start time, can we just say it starts at a hardcoded time?
3. This is a big one, but next to the code implementation we need unittests to make sure everything works as expected. This requires testing unique functions to see the outcome is as expected. Let me know when you need help with this.
4. Last, you can also update the Changelog, documentation and readme to update the available data providers in this PR.

Other than that I have added some small questions on specific parts on the code because I do not have access to the Fifa data. I would appreciate it if you can answer on question and resolve comments that you fix in the next PR.

Looking forward to finishing this PR soon!

[Alek050]

Hi @ouyang1030,

Thanks for integrating the tests, those look great.

I think you tried to merge the most recent develop branch and accidentaly removed working code in get_game because I can not see any code utilizing the _get_fifa_event_data functions there. Can you still add and test that?

Other than that I think it only needs updated documentation, changelog, and readme and we can push it through.

One more thing, can you remind me what you did regarding the NaT I asked about in my first comment?

Great work!

[ouyang1030]

Hi @ouyang1030,

Thanks for integrating the tests, those look great.

I think you tried to merge the most recent develop branch and accidentaly removed working code in get_game because I can not see any code utilizing the _get_fifa_event_data functions there. Can you still add and test that?

Other than that I think it only needs updated documentation, changelog, and readme and we can push it through.

One more thing, can you remind me what you did regarding the NaT I asked about in my first comment?

Great work!

okay, regarding the NaT you asked, i only kept the pass and shot event for now, and other event.