Open
Conversation
Dmitry-E
reviewed
Apr 17, 2023
| depends_on: | ||
| - db | ||
| environment: | ||
| - SPRING_DATASOURCE_URL=jdbc:postgresql://db:5432/postgres |
There was a problem hiding this comment.
в environment для server лучше добавить имя и пароль для подключения к БД
| @@ -0,0 +1,3 @@ | |||
| FROM amazoncorretto:11 | |||
There was a problem hiding this comment.
-
лучше добавить VOLUME, чтобы анализировать проблемы нужно иметь доступ к логам приложения.
Посмотри как можно получить логи приложения с VOLUME и без него. -
приложения обычно запускается с набором JAVA_OPTS например для настроек GC, и объёмы памяти.
попробуй добавить переменную JAVA_OPTS в ENTRYPOINT и залогируй на старте приложения получнные опции
| import javax.validation.constraints.PositiveOrZero; | ||
| import java.util.List; | ||
|
|
||
| @RestController |
There was a problem hiding this comment.
в сервер осталась валидация через @validated
docker-compose.yml
Outdated
| - "8080:8080" | ||
| depends_on: | ||
| - server | ||
| - db |
There was a problem hiding this comment.
по заданию gateway к БД не подключается, поэтому зависимость db можно убрать
Dmitry-E
reviewed
Apr 19, 2023
start-app.sh
Outdated
| @@ -0,0 +1,2 @@ | |||
| #!/bin/bash | |||
| run docker-compose.yml No newline at end of file | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.