Fixed manifest 404 errors #556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes non-standard web manifest extensions and references to icons that were causing 404 errors, while properly relocating the Safari pinned tab icon reference to the layout metadata.
- Removed custom
ManifestWithScopeExtensionstype and non-standard manifest properties - Removed references to icons that don't exist (
safari-pinned-tab.svgandfavicon.icofrom manifest) - Moved
safari-pinned-tab.svgreference to the proper location in layout metadata
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/app/manifest.ts | Removed custom type definition and non-standard manifest properties (scope_extensions, edge_side_panel) along with invalid icon references |
| src/app/layout.tsx | Changed icons.other from object to array format and added mask-icon reference for Safari pinned tab |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.