Skip to content

Conversation

@AlexJSully
Copy link
Owner

@AlexJSully AlexJSully commented Oct 11, 2025

This pull request improves error handling and user feedback for missing or failed article loads, updates dependencies, and enhances test coverage. The most significant changes are grouped below.

Error Handling and User Feedback:

  • The ArticleFiller.displayError method now provides a styled error message with Bootstrap, including "Refresh" and "Home" buttons for better user experience. Error messages are more robust and handle empty or undefined input gracefully.
  • Improved error handling in ArticleFiller.grabArticle: now checks for non-OK HTTP responses and displays a detailed error message with the status code and text.
  • Added a new Cypress test to verify that an appropriate error is shown when an article is missing.
image

Testing Improvements:

  • Updated unit tests for displayError to check for the presence of error messages in the DOM, and added tests for handling fetch failures with non-OK responses in grabArticle. [1] [2]

Dependency and Configuration Updates:

  • Updated development dependencies in package.json, including cypress, eslint, jest, and others, to their latest versions.
  • Changed the start script in package.json to disable caching for the local server.
  • Updated Bootstrap to version 5.3.8.

Code Robustness:

  • Improved nullish checks and defensive coding in several places, such as error handling and content conversion, to prevent runtime errors.

Configuration Cleanup:

  • Removed the deprecated experimentalStudio flag from the Cypress configuration.

@AlexJSully AlexJSully requested a review from Copilot October 11, 2025 20:16
@AlexJSully AlexJSully self-assigned this Oct 11, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates Bootstrap from version 5.3.7 to 5.3.8, improves error handling with styled error messages and user-friendly buttons, and enhances test coverage. This PR focuses on better user experience during error scenarios and ensures the application gracefully handles failed article fetches.

  • Updated Bootstrap to version 5.3.8 with minor styling improvements
  • Enhanced error handling with Bootstrap-styled error messages including "Refresh" and "Home" buttons
  • Improved test coverage for error scenarios and updated development dependencies

Reviewed Changes

Copilot reviewed 21 out of 52 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/scripts/libraries/bootstrap/* Updated Bootstrap framework from v5.3.7 to v5.3.8
src/scripts/index.js Enhanced error handling with styled messages and improved fetch error checking
src/scripts/index.test.js Updated tests to verify error message display and added fetch failure test cases
package.json Updated development dependencies and modified start script to disable caching
cypress/e2e/landing.cy.js Added test for missing article error handling
cypress.config.js Removed deprecated experimentalStudio flag

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@AlexJSully AlexJSully merged commit e1f85d9 into master Oct 11, 2025
5 checks passed
@AlexJSully AlexJSully deleted the alexjsully-251011-fix-fetch-error-ui branch October 11, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants