Moved service worker into index.js
#77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates service worker registration by moving it from inline HTML script to the main index.js file, improving code organization and testability.
Key Changes:
- Service worker registration moved from
index.htmltoindex.jswith async/await pattern and error handling - Added comprehensive unit tests for service worker registration scenarios
- Updated dependencies to latest versions
Reviewed changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/scripts/index.js | Added registerServiceWorker function with error handling and integrated it into window.onload |
| src/scripts/index.test.js | Added test suite covering service worker registration success and failure cases |
| index.html | Removed inline service worker registration script |
| src/icon/site.webmanifest | Fixed typo in "sizes" property and added icon configurations for shortcuts |
| package.json | Updated development dependencies to latest versions |
| cypress/e2e/landing.cy.js | Enhanced test to simulate service worker registration failure scenario |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.