Retain logical sample metadata columns when merging#327
Merged
sjspielman merged 4 commits intomainfrom Oct 9, 2025
Merged
Conversation
jashapiro
approved these changes
Oct 9, 2025
Member
jashapiro
left a comment
jashapiro
left a comment
There was a problem hiding this comment.
LGTM, with a suggestion to be just a bit more judicious in mutation.
Co-authored-by: Joshua Shapiro <josh.shapiro@ccdatalab.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #302
Stacked on #325
This PR makes some very minor changes to ensure that logical columns in the sample metadata stay logical when merging. I made the assumption which* I think is reasonable and future-proof that columns starting with
is_should remain logical and not be switched to character. Let me know if you think that is too prescriptive.I also slightly modified one of the tests to implicitly also check types, to ensure non
^is_columns are character but^is_are logical.