Conversation
sjspielman
approved these changes
Oct 23, 2025
Member
sjspielman
left a comment
sjspielman
left a comment
There was a problem hiding this comment.
These changes look consistent to me 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #329
Here I am porting over the changes from AlexsLemonade/scpca-nf#1072 and related PRs in that repo to add AWS ECR push to this repo.
There are a few differences here, mostly because we don't have separate test and push workflows, so there are a few more conditionals here, including conditionally setting the GitHub environment (which has to be done to connect to AWS).
Otherwise the code should follow the same patterns as those previous PRs.