Conversation
jashapiro
reviewed
Oct 27, 2025
Member
jashapiro
left a comment
jashapiro
left a comment
There was a problem hiding this comment.
The point release update seems fine to me. I don't know why the xgboost change is there, but I would not include it, as we want to point to a CRAN repo in general, not specific URLS.
renv.lock
Outdated
| "Package": "xgboost", | ||
| "Version": "1.7.11.1", | ||
| "Source": "Repository", | ||
| "Source": "URL", |
Member
There was a problem hiding this comment.
I don't know how this got changed to URL, but I would undo the xgboost changes here.
Member
Author
There was a problem hiding this comment.
ah, well...
https://github.com/AlexsLemonade/scpcaTools/actions/runs/18848990786/job/53780510484#step:8:3002
Oh, this seems like an outdated run that my github notifier just notified me late about!
| "HDF5Array": { | ||
| "Package": "HDF5Array", | ||
| "Version": "1.32.0", | ||
| "Version": "1.32.1", |
Member
There was a problem hiding this comment.
This change of a minor point release seems just fine to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm filing this PR not necessarily for merging (?) but at least for feedback and perhaps a 🌮 . These are the changes I ended up making to
renv.lockto be able to get up and running on my new cache-less computer. I recorded the new hdf5array version, and snapshotted (and renv did this xgboost changes along the way).I guess the feedback I'm looking for via this is PR is, can we confirm this was all reasonable to have done for myself at a local level, or offer other suggestions for fighting with renv? Now, if you find it very reasonable, so reasonable that we should all be so reasonable, you can optionally also formally review it for merging (*and I'll have to make other renv file changes in that case).