Skip to content

Update scAdvanced GSEA and AUCell notebooks#910

Merged
sjspielman merged 11 commits intomasterfrom
sjspielman/898-update-gsea-aucell
Feb 13, 2026
Merged

Update scAdvanced GSEA and AUCell notebooks#910
sjspielman merged 11 commits intomasterfrom
sjspielman/898-update-gsea-aucell

Conversation

@sjspielman
Copy link
Member

Closes #898

This PR updates the GSEA and AUCell notebooks for bioconductor 3.22. Changes includes:

  • msgidbr now takes the argument(s) (sub)collection and not (sub)category, so I updated this in both notebooks
  • For AUCell, I also updated so it no longer uses GeneSetCollections but a named list with gene sets. I also updated the plot_recovery_curve function in utils accordingly. Let me know if there are any parts here you'd like to see done differently (e.g. some purrr code that replaces genesetcollection code)
  • I also did some recreational spacing updates while here to clean up a bit.

You can see rendered versions of these notebooks here:

And for comparison, December 2025 schedule links: https://alexslemonade.github.io/2025-december-training/workshop/SCHEDULE.html

There aren't changes to the GSEA output, but there are small changes to some of the AUCell scores. This barely affects thresholds and does not affect results, so these changes are reasonably consistent with what one might expect for a version bump

@sjspielman
Copy link
Member Author

Realizing after filing this that GHA may fail because of similar changes needed to the pathway-analysis notebooks. If/when that happens, I will just have to fold those changes into this PR, but the diffs will be small!

@sjspielman
Copy link
Member Author

Realizing after filing this that GHA may fail because of similar changes needed to the pathway-analysis notebooks. If/when that happens, I will just have to fold those changes into this PR, but the diffs will be small!

Ok, in retrospect this was obviously going to happen.... It didn't fail at the pathway notebooks because it failed sooner, at the cell type notebook which is being fixed in #906. I guess the only way to get CI passing for individual PRs will be to turn it off temporarily (which I don't love the idea of doing - it already caught a bug for us!), or I'll have to make one big PR with all the notebooks.

There are 6 notebooks here with content that needs to change because it errors in bioc 3.22: all the pathway notebooks (2 in scAdvanced and 3 in pathway-analysis; aside from AUCell, this is mostly msigdbr updated syntax), and the singler notebook. Would either @jashapiro or @allyhawkins be up for reviewing a larger PR, or would like to suggest a different strategy?

@jashapiro
Copy link
Member

Would either @jashapiro or @allyhawkins be up for reviewing a larger PR, or would like to suggest a different strategy?

You can temporarily disable rendering for notebooks in https://github.com/AlexsLemonade/training-modules/blob/master/scripts/render-live.sh

If you do that, I would file a separate issue just to be sure everything in reenabled as a final test (but try to reenable as you go)

@sjspielman
Copy link
Member Author

You can temporarily disable rendering for notebooks in https://github.com/AlexsLemonade/training-modules/blob/master/scripts/render-live.sh

Just to be extra sure - I read this as suggesting commenting out lines and then restoring as I go, yes?

@jashapiro
Copy link
Member

Just to be extra sure - I read this as suggesting commenting out lines and then restoring as I go, yes?

Yes, correct.

@sjspielman sjspielman marked this pull request as ready for review February 13, 2026 13:59
Copy link
Member

@allyhawkins allyhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


`AUCell` uses gene sets in a particular format that comes from the `GSEABase` package.
We need to create a `GeneSetCollection`.
We can provide these gene sets as a named list to `AUCell`, so let's create that now.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a little on the fence on removing this because the GeneSetCollection is still supported, but I think I agree that this is cleaner and more straightforward.

@sjspielman sjspielman merged commit 5026246 into master Feb 13, 2026
2 checks passed
@sjspielman sjspielman deleted the sjspielman/898-update-gsea-aucell branch February 13, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update advanced gene set analysis notebooks for new Bioc version

3 participants