prevent query error on scoped entity when filter=W10=#2
Open
westwoodworm wants to merge 3 commits intomainfrom
Open
prevent query error on scoped entity when filter=W10=#2westwoodworm wants to merge 3 commits intomainfrom
westwoodworm wants to merge 3 commits intomainfrom
Conversation
Contributor
|
This MR has no explanation. |
Contributor
Author
|
Added a query validator to avoid invalid filter caused errors. |
mermetbt
reviewed
Jan 15, 2024
src/Pachyderm/Orm/QueryBuilder.php
Outdated
|
|
||
| if ($field instanceof QueryBuilder) { | ||
| if (empty($field->build())) return $this; | ||
| $this->append($globalOperator, $field->build()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The filter param has no validation so prone to have errors. When the Model/paginate method calls self::findAll with 1st argument $paginator->filters() as default value empty array, it will then be serialized to 'W10=' which will lead to a query error. Or else this should be avoided when passing the api params.