Skip to content

add workflow for installing dependencies with yarn as package manager#1

Merged
interim17 merged 3 commits intomainfrom
setup_yarn
Feb 13, 2026
Merged

add workflow for installing dependencies with yarn as package manager#1
interim17 merged 3 commits intomainfrom
setup_yarn

Conversation

@interim17
Copy link
Collaborator

@interim17 interim17 commented Feb 11, 2026

The setup_npm.yml workflow should hopefully work for any repo that uses npm as its project manager.

However, some repos at AICS use yarn as a package manager (idea-board, cell catalog), some also use bun (I don't know of any projects at AICS using pnpm). Different package managers might resolve dependencies differently, trying to call npm install in idea-board failed.

I added a yarn flavored version of the setup workflow and was able to call it successfully by referencing the commit in idea-board.
AllenCell/idea-board#48

Screenshot 2026-02-11 at 8 25 38 AM

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a reusable GitHub Actions workflow for setting up Node.js projects that use Yarn as their package manager, addressing the need to support different package managers across AICS repositories.

Changes:

  • Added a new reusable workflow setup_yarn.yml with configurable Node.js and Yarn versions
  • Configured the workflow to cache Yarn dependencies and install them using --frozen-lockfile flag
  • Set default versions to Node.js 24 and Yarn 1.22.22

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@ShrimpCryptid ShrimpCryptid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, otherwise LGTM

Comment on lines 21 to 23
uses: actions/checkout@v4
- name: Setup node
uses: actions/setup-node@v4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pin specific commit hashes for security?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made this workflow match the other one (v6.2.0 via hash)

workflow_call:
inputs:
node-version:
required: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good choice, we should probably make node-version and npm-version inputs in setup_npm.yml also not required

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll tack that on this PR

@interim17 interim17 merged commit 7ae08fc into main Feb 13, 2026
@interim17 interim17 deleted the setup_yarn branch February 13, 2026 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants