Normalize quotation marks in PDF bookmarks #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
可以，我弄完下个版本就merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the package manual
physics2.pdf, all PDF bookmarks use quotation marks“<module>”(because they are all marked by\modu{<module>}) except for one, which uses the raw LaTeX-style``legacy''(because this one is input with``legacy'').This PR normalize the exception so no PDF bookmarks contain
``...''quotation marks.Considering here the
legacyis not a module name, but represents a family of modules,``legacy''is replaced with a use of low-level\texorpdfstring, rather than\modu{legacy}.physics2/doc/phy2docdef.tex
Line 28 in f8f5be1