Open
Conversation
LucasLima939
commented
Jan 17, 2025
LucasLima939
commented
- Update Android project.
- Remove cupertino version to fetch newest.
Amir-P
requested changes
Feb 25, 2025
Owner
Amir-P
left a comment
Amir-P
left a comment
There was a problem hiding this comment.
Thanks for contributing! Left two comments. PTAL.
| lintOptions { | ||
| disable 'InvalidPackage' | ||
| } | ||
| namespace 'com.example.power' |
Owner
There was a problem hiding this comment.
The namespace is not correct. This namespace is for the android project of the example app not the plugin.
| # The following adds the Cupertino Icons font to your application. | ||
| # Use with the CupertinoIcons class for iOS style icons. | ||
| cupertino_icons: ^0.1.3 | ||
| cupertino_icons: |
Owner
There was a problem hiding this comment.
I think the cupertino_icons can be completely removed from the example project since it's not used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.