This repository was archived by the owner on May 14, 2025. It is now read-only.
fix: [#152] - use a.isEqual check instead of calling DeepEqual again#153
Open
adwski wants to merge 3 commits intoAmitKumarDas:masterfrom
Open
fix: [#152] - use a.isEqual check instead of calling DeepEqual again#153adwski wants to merge 3 commits intoAmitKumarDas:masterfrom
adwski wants to merge 3 commits intoAmitKumarDas:masterfrom
Conversation
…Equal again Signed-off-by: Artem Dvoretskii <adwski@users.noreply.github.com>
Signed-off-by: Artem Dvoretskii <adwski@users.noreply.github.com>
Collaborator
|
does it touched only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose to check for changes in merged child object without considering lastApplied annotation. It seems that it is not guaranteed to be exactly the same after child is observed.