Fix scrollbar on mobile issue #333#351
Open
gry-dmitrij wants to merge 3 commits intoAndarist:mainfrom
Open
Conversation
scrollHeight is rounded. So when scrollHeight is float scrollbar shows on the chrome mobile browser even if there is nowhere to scroll to. I found only one way: increase the scroll by 1 px
|
Contributor
|
Would love to see this merged |
Contributor
|
Any chance this can get merged? |
Author
|
If urgently needed, I posted the changes here |
Andarist
reviewed
Feb 28, 2026
|
|
||
| const getHeight = (node: HTMLElement, sizingData: SizingData): number => { | ||
| const height = node.scrollHeight; | ||
| const height = node.scrollHeight + 1; |
Owner
There was a problem hiding this comment.
This should be rounded using Math.round or Math.ceil.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scrollHeight is rounded. So when scrollHeight is float scrollbar shows on the chrome mobile browser even if there is nowhere to scroll to.
I found only one way: increase the scroll by 1 px