Lazy #2
Open
Lazy #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LazyInterface/LazyInterface/ILazy.cs
Outdated
Comment on lines
5
to
6
| namespace LazyInterface | ||
| { |
There was a problem hiding this comment.
используйте file-scoped неймспейсы
Suggested change
| namespace LazyInterface | |
| { | |
| namespace LazyInterface; |
|
|
||
| private T? result; | ||
|
|
||
| private bool flag; |
| ArgumentNullException.ThrowIfNull(supplier); | ||
|
|
||
| this.supplier = supplier; | ||
| this.flag = false; |
There was a problem hiding this comment.
это можно не писать -- дефолтное значение для boolean-поля
| this.supplier = null; | ||
| } | ||
|
|
||
| return this.result; |
There was a problem hiding this comment.
чтобы линтер не ругался, лучше пометить возвращаемый тип как T?
| var lazy = new MultithreadedVersion<object>(() => | ||
| { | ||
| Interlocked.Increment(ref callCount); | ||
| Thread.Sleep(150); |
There was a problem hiding this comment.
Чтобы просимулировать одновременный старт потоков, используйте manualResetEvent или Barrier
| public class SingleThreadedTests | ||
| { | ||
| [Test] | ||
| public void Get_MultipleCalls_ShoulCallSupplierOnlyOnceAndReturnCorrectValue() |
There was a problem hiding this comment.
Чтобы не дублировать тесты на общее поведение для двух реализаций, используйте TestCaseSource для передачи реализаций и интерфейс ILazy в каждом общем тесте
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.