-
Notifications
You must be signed in to change notification settings - Fork 1
coordinate v29 upgrade #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sucildossj
commented
Oct 31, 2025
- included cmake upgrade
- included bip360 implementation
… to link issue on ubuntu
disable precommitment and fix signet crash
1. include class for generation and signing tx from p2tsh 2. createwallet changes 3. wallet changes fpr supporting create wallet
An 483 include p2tsh support
- include cache to fix rebuild from scratch - include docker permission
|
The above commit should have been it's own PR. This way, the P2TSH changes can be viewed and reviewed on their own. Is it possible to clean up the PR? So that we can include changes that are not related to P2TSH. Decreasing the size of the batch size will have many beneficial results. |
Contributor
Author
|
I created a separate PR for P2TSH last week. Due to containerization changes, I merged it into the v2 branch yesterday. |
Fix p2tsh internal key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.