Skip to content

Conversation

@michaeljyeates
Copy link

C++ std v20 is needed to compile

Change Description

Change CMAKE_CXX_STANDARD to 20 from 17, it uses std::span which gives this error when using v17

note: ‘std::span’ is only available from C++20 onwards
21 | inline thread_local std::spanstd::byte code_memory_range;

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

C++ std v20 is needed to compile
@spoonincode
Copy link
Contributor

This change has already been made in main, as well as the commit of eos-vm that spring 1.1 is based on. Any reason you are targeting this change for spring 1.0 release branch version of eos-vm? As far as I know this c++17 vs c++20 setting doesn't affect building of spring. And I don't think we'd take a non-critical fix for 1.0.x now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants