fix: handle missing config file gracefully#5
Open
njg7194 wants to merge 1 commit intoApexOpsStudio:mainfrom
Open
fix: handle missing config file gracefully#5njg7194 wants to merge 1 commit intoApexOpsStudio:mainfrom
njg7194 wants to merge 1 commit intoApexOpsStudio:mainfrom
Conversation
- Add DEFAULT_CONFIG constant with sensible defaults - Create default config file when missing instead of crashing - Create parent directories if they don't exist - Inform user when default config is created - Add comprehensive tests for missing and existing config scenarios Closes ApexOpsStudio#2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the crash that occurs when
~/.config/task-cli/config.yamlis missing.Changes
DEFAULT_CONFIGconstant with sensible default values matchingconfig.yaml.exampleload_config()to:Acceptance Criteria
Testing
Run tests with:
Closes #2