feat: update to capacitor 8 and support SPM#185
feat: update to capacitor 8 and support SPM#185riderx wants to merge 2 commits intoAppsFlyerSDK:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the AppsFlyer Capacitor plugin from Capacitor 7 to Capacitor 8 and adds Swift Package Manager (SPM) support for iOS. The title contains a typo ("upcate" should be "update").
Key Changes:
- Updates Capacitor core and platform dependencies from version 7 to version 8
- Adds Swift Package Manager support via new Package.swift file
- Updates iOS deployment target from 14.0 to 15.0
- Updates Android minimum SDK from 23 to 24, and compile/target SDK from 35 to 36
- Migrates rollup configuration from CommonJS to ES modules (.mjs)
- Updates various development dependencies and build tools
Reviewed changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| rollup.config.mjs | New ES module-based rollup configuration replacing the old .js file |
| Package.swift | New Swift Package Manager manifest defining iOS package structure and dependencies |
| package.json | Updates Capacitor dependencies to v8, modernizes dev dependencies, and references new rollup config |
| ios/Podfile | Increases iOS deployment target to 15.0 for Capacitor 8 compatibility |
| ios/Plugin.xcodeproj/project.pbxproj | Updates Xcode project deployment target settings to iOS 15.0 |
| AppsflyerCapacitorPlugin.podspec | Updates podspec deployment target to 15.0 |
| android/gradlew.bat | Updates Gradle wrapper batch script to newer version |
| android/gradlew | Updates Gradle wrapper shell script to newer version |
| android/gradle/wrapper/gradle-wrapper.properties | Updates Gradle version and adds new configuration properties |
| android/gradle/wrapper/gradle-wrapper.jar | Updates Gradle wrapper JAR binary |
| android/build.gradle | Updates Android dependencies, Kotlin version, and SDK version requirements |
| .prettierignore | Removes build and dist directory ignore rules |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| dependencies: [ | ||
| .product(name: "Capacitor", package: "capacitor-swift-pm"), | ||
| .product(name: "Cordova", package: "capacitor-swift-pm"), | ||
| .product(name: "AppsFlyerLib-Static", package: "AppsFlyerLib") |
There was a problem hiding this comment.
The package name reference is incorrect. The dependency is defined as "AppsFlyerFramework-Static" in the package URL, but here it's referenced as "AppsFlyerLib". These should match the actual package name.
There was a problem hiding this comment.
checked here https://github.com/AppsFlyerSDK/AppsFlyerFramework-Static/blob/main/Package.swift it's correct
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.11.1-all.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.3-all.zip |
There was a problem hiding this comment.
The distributionUrl points to a remote Gradle distribution ZIP that will be downloaded and executed during builds, but there is no accompanying distributionSha256Sum configured to verify the integrity of that artifact. An attacker with the ability to tamper with traffic to services.gradle.org (e.g., network MITM or compromised CA) could supply a malicious Gradle distribution and gain code execution in your build environment. Add a distributionSha256Sum entry with the official SHA‑256 for the gradle-8.14.3-all.zip file so the wrapper verifies the download before executing it.
There was a problem hiding this comment.
it's always set like that in capacitor, not sure changing it is a good idea
|
Any updates on this? Would love compatibility with Capacitor 8 (which is needed for Android API 36) @al-af @Dani-Koza-AF |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Following up on my previous message ☝🏻 : @pazlavi @Dani-Koza-AF @ShaharAF @amit-kremer93 |
|
Hi guys. New customer with AppsFlyer (hopefully). We need version 8 for our project, any news on this? |
This PR updates dependencies to Capacitor, which was released 2 weeks ago, and adds support for SPM apps, which became default in Capacitor 8.