Skip to content
This repository was archived by the owner on Sep 21, 2023. It is now read-only.

[SECURITY] Fix Temporary File Information Disclosure Vulnerability #5

Open
JLLeitschuh wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[SECURITY] Fix Temporary File Information Disclosure Vulnerability #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/org/appverse/builder/build/BuildExecutorWorker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

import javax.inject.Inject;
import java.io.*;
import java.nio.file.Files;
import java.util.List;
import java.util.Optional;
import java.util.concurrent.CopyOnWriteArrayList;
Expand Down Expand Up @@ -164,7 +165,7 @@ private File getBuildLogFile() {
if (currentLogFile == null) {
try {
//TODO find a better place to store the log file
currentLogFile = File.createTempFile(currentBuildRequest.getChainId().toString() + "-" + currentBuildRequest.getId(), "log");
currentLogFile = Files.createTempFile(currentBuildRequest.getChainId().toString() + "-" + currentBuildRequest.getId(), "log").toFile();
} catch (IOException e) {
log.warn("Could not create the temporary log file", e);
}
Expand Down
3 changes: 2 additions & 1 deletion src/test/java/org/appverse/builder/build/BuildRequestTestUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import java.io.File;
import java.io.FileInputStream;
import java.io.IOException;
import java.nio.file.Files;

import static org.appverse.builder.domain.enumeration.BuildStatus.QUEUED;
import static org.assertj.core.api.Assertions.assertThat;
Expand Down Expand Up @@ -51,7 +52,7 @@ public void waitStart(BuildRequestDTO buildRequest) throws InterruptedException
}

public BuildChainDTO createBuildChainFromPayload(File nativeDemoDir) throws IOException, ZipException {
File tempFile = File.createTempFile("payload-test", ".zip");
File tempFile = Files.createTempFile("payload-test", ".zip").toFile();
tempFile.delete();
ZipFile zipFile = new ZipFile(tempFile);
ZipParameters parameters = new ZipParameters();
Expand Down
7 changes: 4 additions & 3 deletions src/test/java/org/appverse/builder/web/rest/BuildChainResourceIntTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
import java.io.File;
import java.io.FileInputStream;
import java.io.IOException;
import java.nio.file.Files;
import java.time.Instant;
import java.time.ZoneId;
import java.time.ZonedDateTime;
Expand Down Expand Up @@ -327,7 +328,7 @@ public void onlyOwnerCanDeleteBuildChain() throws Exception {
@Test
public void createBuildChainFromPayload() throws Exception {
File nativeDemoDir = new ClassPathResource("demo/native").getFile();
File tempFile = File.createTempFile("payload-test", ".zip");
File tempFile = Files.createTempFile("payload-test", ".zip").toFile();
tempFile.delete();
ZipFile zipFile = new ZipFile(tempFile);
ZipParameters parameters = new ZipParameters();
Expand Down Expand Up @@ -376,7 +377,7 @@ public void createBuildChainFromPayload() throws Exception {
@Test
public void createBuildChainFromPayloadWithOptions() throws Exception {
File nativeDemoDir = new ClassPathResource("demo/native").getFile();
File tempFile = File.createTempFile("payload-test", ".zip");
File tempFile = Files.createTempFile("payload-test", ".zip").toFile();
tempFile.delete();
ZipFile zipFile = new ZipFile(tempFile);
ZipParameters parameters = new ZipParameters();
Expand Down Expand Up @@ -429,7 +430,7 @@ public void createBuildChainFromPayloadWithOptions() throws Exception {
@Test
public void createBuildChainFromPayloadWithFlavor() throws Exception {
File nativeDemoDir = new ClassPathResource("demo/native").getFile();
File tempFile = File.createTempFile("payload-test", ".zip");
File tempFile = Files.createTempFile("payload-test", ".zip").toFile();
tempFile.delete();
ZipFile zipFile = new ZipFile(tempFile);
ZipParameters parameters = new ZipParameters();
Expand Down