-
Notifications
You must be signed in to change notification settings - Fork 39
CAP-1609 Fixes for various samples for Pythong, Go, Ruby and PHP #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rogerk-apryse
wants to merge
15
commits into
next_release
Choose a base branch
from
rogerk/CAP-1609-fixes-samples-go-lang
base: next_release
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
CAP-1609 Fixes for various samples for Pythong, Go, Ruby and PHP #187
rogerk-apryse
wants to merge
15
commits into
next_release
from
rogerk/CAP-1609-fixes-samples-go-lang
+333
−259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added TaggingOptions for AnnotInsertWithTagging (#161) - Python - PHP - Ruby - GO * [Samples] Update the TimestampAndEnableLTV test in DigitalSignaturesTest to use the correct root certificate of the timestamping signature. * Updates Python to use Py_LIMITED for supporting universal Python 3 builds. (#164) * Fix issue with CMake syntax. * Expose the iceni find replace functionality api (CI-1352) (#165) * [Python] Fix for make install. * Fixes for universal mac build. (#169) * [Samples] Remove semicolon in PYTHON/OfficeTemplateTest.py. (#170) * Fix issues with backwards compatibility on build system. * Revert cmake changes. * restore non Apple else code * Updated TransPDF samples to use find-replace-test.pdf * DocClassification samples * Revert "DocClassification samples" This reverts commit 05314b0. * DocClassification samples (#174) --------- Co-authored-by: myang-apryse <michael.yang@apryse.com> Co-authored-by: Dan Chen <7284050+overocean@users.noreply.github.com> Co-authored-by: Tamas Demjen <tdemjen@apryse.com> Co-authored-by: Rainer Schaaf <rschaaf@apryse.com> Co-authored-by: simoncrowfoot <scrowfoot@apryse.com> Co-authored-by: simoncrowfoot <75724490+simoncrowfoot@users.noreply.github.com>
Merge pre_releease into master for release version 11.10.0
Small fixes to find the external module dependencies
The EncTest that the wrappers run is interactive (it asks the user to provide a password.) Changed it to non-interactive. This is needed so that they do not fail when ran from the CorePWSTester.
The Go DataExtraction_test was failing because of a call to set a new Rect with int values but the call expects floats.
overocean
reviewed
Jan 15, 2026
Samples/EncTest/GO/Enc_test.go
Outdated
| for count < 3{ | ||
| fmt.Println("A password required to open the document.") | ||
| var password string | ||
| fmt.Print("Please enter the password: \n") |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove this line and also the commented out lines?
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Addressing PR comments
- Fixes for the OCRTest samples to work with the IRIS OCR module if present. Before the change, if the module is present, and we are not requesting the use of that module, it was giving an error. - Removed test case number 7 from these tests as it was previously removed from the CPP and Java tests but not from these. Test 7 is expected to fail.
Small fix for PHP OCRTest
Python done, remaining Go, Ruby and PHP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review my commits individually