Merged
Conversation
wangshijun
reviewed
Jan 10, 2026
|
|
||
| // Collect component list for each app | ||
| metricAppComponentList?.reset(); | ||
| pAll( |
There was a problem hiding this comment.
这里感觉效率不行，只有当某个进程变动之后才有重新获取的必要，不然每次都重复执行，拿到相同的结果，对于监控模块来说，太浪费了
Author
There was a problem hiding this comment.
结论: 不需要改
原因: 进程不变动不代表组件的版本也没有变化，不代表 3 大 store 的版本没有变化。这一层是不能缓存的，原因是组件的版本随时都可能发生变化(它的获取只是读取环境变量，非常高效，遍历的变量也是早就有的)，3 大 store 的版本也可能发生变化(而它已经被缓存了，缓存时长为 5 min)。
There was a problem hiding this comment.
缓存时长调整为小时级别即可，不需要那么快就失效，另外这里的请求有没有对组件做去重呢？内存消耗会增加多少？
Author
There was a problem hiding this comment.
缓存时长 1h 感觉有点太长了，更新完成之后估计也要很久才知道 3 大 store 有没有更新好，要不改成 10 min 怎么样。内存消耗增加不明显，内存是波动的。我对比了一下，增加了 4 m 左右这样，但是我用 keyv.js 都没有缓存多少条目，估计只是波动引起的。
- 更新前内存
- 更新后内存
wangshijun
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
关联 Issue
主要改动
界面截图
测试计划
检查清单