Skip to content

Removed keystroke support for 'delete' #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YOUR1 merged 1 commit into from
Oct 1, 2025
Merged

Removed keystroke support for 'delete' #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ReleaseNotes.wiki
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
; Version 2.1.3 (Oct 1, 2025)
* Improved keyboard keystroke behaviour, removed support for delete button due to complexity
; Version 2.1.2 (Aug 14, 2025)
* Added image validation
* Fixed a bug on the special page where pages with a different namespace couldn't be filtered
Expand Down
2 changes: 1 addition & 1 deletion extension.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"Robin van der Wiel",
"Yvar Nanlohij"
],
"version": "2.1.2",
"version": "2.1.3",
"url": "https://www.archixl.nl",
"descriptionmsg": "sic-desc",
"license-name": "GPL-2.0+",
Expand Down
2 changes: 1 addition & 1 deletion resources/frontend/dist/smartcomments.min.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion resources/frontend/dist/smartcomments.min.js.map
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion resources/frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@smartcomments/frontend",
"version": "1.0.0",
"version": "1.0.1",
"description": "SmartComments Frontend Library - Vue 3 components and utilities for MediaWiki",
"type": "module",
"scripts": {
Expand Down
2 changes: 0 additions & 2 deletions resources/frontend/src/composables/ui/useKeyboardShortcuts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ function useKeyboardShortcuts(commentsStore) {
// Otherwise close the comment dialog
commentsStore.closeCommentDialog();
}
} else if (event.key === "Delete" && commentsStore.activeComment) {
commentsStore.deleteComment(commentsStore.activeComment);
} else if (event.key === "ArrowDown" && commentsStore.hasNextComment) {
commentsStore.navigateComment("next");
} else if (event.key === "ArrowUp" && commentsStore.hasPreviousComment) {
Expand Down
Loading