Implement check-for-updates and auto-update by amilcarlucas · Pull Request #1357 · ArduPilot/MethodicConfigurator

amilcarlucas · 2026-03-06T18:50:27Z

@OmkarSarkar204 can you take a look at this?

Copilot

Pull request overview

Adds macOS-native update support by downloading and installing a .dmg when available, while keeping existing Windows installer and Linux/PyPI (pip/uv) paths intact.

Changes:

Implemented macOS DMG download/mount/copy/unmount update flow and integrated it into the update manager.
Generalized URL and downloaded-file validation helpers for reuse across platforms.
Expanded unit tests to cover macOS DMG helpers and the new update-manager macOS branching behavior.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`ardupilot_methodic_configurator/backend_internet.py`	Adds macOS DMG install pipeline and shared validation helpers used by update flows.
`ardupilot_methodic_configurator/data_model_software_updates.py`	Routes macOS updates to DMG installer when present; otherwise falls back to pip.
`tests/unit_backend_internet.py`	Adds unit tests for new macOS DMG helpers and shared validation utilities.
`tests/unit_data_model_software_updates.py`	Adds tests for macOS update-manager behavior (DMG path, fallback, failures).
`ARCHITECTURE_1_software_update.md`	Documents new macOS DMG update approach and helper functions.

Copilot · 2026-03-06T18:55:48Z

tests/unit_backend_internet.py

 )

-# pylint: disable=unused-argument
+# pylint: disable=unused-argument, too-many-lines, redefined-outer-nam


The pylint directive is misspelled (redefined-outer-nam), so pylint won’t actually disable redefined-outer-name and CI/linting may fail. Rename it to redefined-outer-name.

Suggested change

# pylint: disable=unused-argument, too-many-lines, redefined-outer-nam

# pylint: disable=unused-argument, too-many-lines, redefined-outer-name

Copilot · 2026-03-06T18:55:48Z

ardupilot_methodic_configurator/backend_internet.py

+        if progress_callback:
+            progress_callback(0.0, _("Installing {}...").format(app_name))
+
+        # Use ditto to preserve metadata, resource forks, and extended attributes
+        subprocess.check_call(["ditto", app_path, dest])  # noqa: S603, S607
+
+        if progress_callback:
+            progress_callback(100.0, _("Installation complete"))
+


Progress reporting is duplicated and potentially conflicting: _install_app_from_mount() emits 0.0 and 100.0, and _mount_and_install_dmg() also emits 0.0 and 100.0. This can lead to repeated 0%/100% updates with different messages. Consider centralizing progress reporting in one place (e.g., only in _mount_and_install_dmg()), or use distinct progress ranges per phase (mount/install/unmount) so progress is monotonic and messages aren’t overwritten at the same percentage.

Suggested change

if progress_callback:

progress_callback(0.0, _("Installing {}...").format(app_name))

# Use ditto to preserve metadata, resource forks, and extended attributes

subprocess.check_call(["ditto", app_path, dest]) # noqa: S603, S607

if progress_callback:

progress_callback(100.0, _("Installation complete"))

# Use ditto to preserve metadata, resource forks, and extended attributes

subprocess.check_call(["ditto", app_path, dest]) # noqa: S603, S607

Copilot · 2026-03-06T18:55:48Z

ardupilot_methodic_configurator/backend_internet.py

+    if progress_callback:
+        progress_callback(0.0, _("Mounting DMG..."))


Progress reporting is duplicated and potentially conflicting: _install_app_from_mount() emits 0.0 and 100.0, and _mount_and_install_dmg() also emits 0.0 and 100.0. This can lead to repeated 0%/100% updates with different messages. Consider centralizing progress reporting in one place (e.g., only in _mount_and_install_dmg()), or use distinct progress ranges per phase (mount/install/unmount) so progress is monotonic and messages aren’t overwritten at the same percentage.

Copilot · 2026-03-06T18:55:49Z

ardupilot_methodic_configurator/backend_internet.py

+    if result:
+        if progress_callback:
+            progress_callback(100.0, _("Installation complete. Please restart the application."))
+        logging_info(_("macOS DMG installation complete. Please restart the application."))


Progress reporting is duplicated and potentially conflicting: _install_app_from_mount() emits 0.0 and 100.0, and _mount_and_install_dmg() also emits 0.0 and 100.0. This can lead to repeated 0%/100% updates with different messages. Consider centralizing progress reporting in one place (e.g., only in _mount_and_install_dmg()), or use distinct progress ranges per phase (mount/install/unmount) so progress is monotonic and messages aren’t overwritten at the same percentage.

Copilot · 2026-03-06T18:55:49Z

ardupilot_methodic_configurator/backend_internet.py

+def _validate_github_url(url: str) -> bool:
    """Validate that URL is from a trusted GitHub source."""
    # This whitelist is intentionally restrictive for security reasons
    if url.startswith("https://github.com/"):
        return True
-    logging_error(_("Windows installer URL must be from github.com: %s"), url)
+    logging_error(_("Installer URL must be from github.com: %s"), url)
    return False


Using startswith(\"https://github.com/\") is a brittle URL validation approach (e.g., it won’t handle case normalization, leading/trailing whitespace, or other valid GitHub URL forms consistently). A more robust and security-oriented approach is to parse the URL (e.g., via urllib.parse.urlparse) and strictly validate scheme == \"https\" and hostname == \"github.com\" (optionally also constraining the path prefix to /OWNER/REPO/releases/download/).

tests/unit_backend_internet.py

github-actions · 2026-03-06T19:18:44Z

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines	Covered	Coverage	Threshold	Status
11652	10627	91%	89%	🟢

New Files

No new covered files...

Modified Files

File	Coverage	Status
ardupilot_methodic_configurator/backend_internet.py	90%	🟢
ardupilot_methodic_configurator/data_model_software_updates.py	100%	🟢
TOTAL	95%	🟢

updated for commit: 29d5a7e by action🐍

github-actions · 2026-03-06T19:26:06Z

Test Results

2 files 2 suites 28m 37s ⏱️
3 103 tests 3 098 ✅ 5 💤 0 ❌
6 206 runs 6 196 ✅ 10 💤 0 ❌

Results for commit 29d5a7e.

♻️ This comment has been updated with latest results.

OmkarSarkar204 · 2026-03-06T19:46:48Z

@OmkarSarkar204 can you take a look at this?

Sure , do you want me to test something specific locally or should i go ahead and try to fix the errors?

amilcarlucas · 2026-03-06T19:59:36Z

It would be great if you could test that it works.

OmkarSarkar204 · 2026-03-06T20:29:15Z

@amilcarlucas , I hardcoded my local version to 2.9.10 to trigger the update. The app successfully downloaded the 2.9.13 .dmg, mounted it, and copied the .app over without any issues. Works perfectly!

logs:

2026-03-07 01:52:22,686 - INFO - Running version: 2.9.10 (git hash: acc46af6b3207eb1c6f40c4d363ce1dec1865620)
2026-03-07 01:52:22,686 - INFO - _get_verify_param() return certifi.where /Users/omkarsarkar/Desktop/ArduPilot/Methodic/version-check/methodic-test-clone/.venv/lib/python3.12/site-packages/certifi/cacert.pem
2026-03-07 01:52:28,865 - INFO - Downloading and installing new version for macOS...
2026-03-07 01:52:28,874 - INFO - _get_verify_param() return certifi.where /Users/omkarsarkar/Desktop/ArduPilot/Methodic/version-check/methodic-test-clone/.venv/lib/python3.12/site-packages/certifi/cacert.pem
2026-03-07 01:53:16,487 - INFO - macOS DMG installation complete. Please restart the application.
2026-03-07 01:53:20,509 - INFO - Will now exit the old software version.

OmkarSarkar204 · 2026-03-06T20:36:37Z

Just a small thing I noticed that the link(full changelog etc) inside the update banner is not clickable. I dont know if its behavorial or not, i saw it and just wanted to point it out.

amilcarlucas · 2026-03-07T14:35:21Z

@OmkarSarkar204 Thanks for testing and for the feedback.

The URLs are not clickable yet. A webbrowser opens in the backgound with the same information. The user can use that if he wants to click on something.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

ardupilot_methodic_configurator/backend_internet.py

tests/unit_backend_internet.py

ardupilot_methodic_configurator/backend_internet.py

OmkarSarkar204 · 2026-03-07T17:00:40Z

@OmkarSarkar204 Thanks for testing and for the feedback.

The URLs are not clickable yet. A webbrowser opens in the backgound with the same information. The user can use that if he wants to click on something.

Got it. Thanks!

Copilot AI review requested due to automatic review settings March 6, 2026 18:50

amilcarlucas force-pushed the dmg_autoupdate branch from 55a4f8b to acc46af Compare March 6, 2026 18:52

Copilot AI reviewed Mar 6, 2026

View reviewed changes

github-advanced-security bot found potential problems Mar 6, 2026

View reviewed changes

tests/unit_backend_internet.py Fixed Show fixed Hide fixed

Copilot started reviewing on behalf of amilcarlucas March 6, 2026 19:01 View session

amilcarlucas force-pushed the dmg_autoupdate branch from acc46af to 7be6148 Compare March 7, 2026 14:27

feat(macOS): Implement check-for-updates and auto-update

29d5a7e

amilcarlucas force-pushed the dmg_autoupdate branch from 7be6148 to 29d5a7e Compare March 7, 2026 14:32

amilcarlucas requested a review from Copilot March 7, 2026 14:53

Copilot started reviewing on behalf of amilcarlucas March 7, 2026 14:53 View session

Copilot AI reviewed Mar 7, 2026

View reviewed changes

ardupilot_methodic_configurator/backend_internet.py Show resolved Hide resolved

tests/unit_backend_internet.py Show resolved Hide resolved

ardupilot_methodic_configurator/backend_internet.py Show resolved Hide resolved

amilcarlucas merged commit ddae051 into master Mar 7, 2026
35 of 38 checks passed

amilcarlucas deleted the dmg_autoupdate branch March 7, 2026 15:06

	# pylint: disable=unused-argument, too-many-lines, redefined-outer-nam
	# pylint: disable=unused-argument, too-many-lines, redefined-outer-name

		if progress_callback:
		progress_callback(0.0, _("Mounting DMG..."))

Conversation

amilcarlucas commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

☂️ Python Coverage

Overall Coverage

New Files

Modified Files

Uh oh!

github-actions bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

OmkarSarkar204 commented Mar 6, 2026

Uh oh!

amilcarlucas commented Mar 6, 2026

Uh oh!

OmkarSarkar204 commented Mar 6, 2026

Uh oh!

OmkarSarkar204 commented Mar 6, 2026

Uh oh!

amilcarlucas commented Mar 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

OmkarSarkar204 commented Mar 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

amilcarlucas commented Mar 6, 2026 •

edited

Loading

github-actions bot commented Mar 6, 2026 •

edited

Loading

github-actions bot commented Mar 6, 2026 •

edited

Loading