HardwareReport: show vehicle config and output pins#292
HardwareReport: show vehicle config and output pins#292edengilbertus wants to merge 1 commit intoArduPilot:mainfrom
Conversation
IamPete1
left a comment
IamPete1
left a comment
There was a problem hiding this comment.
Param meta data should be loaded from auto generated param docs. We don't currently do it in this tool, but we do in FilterReview. You can generate with ./Tools/autotest/param_metadata/param_parse.py --format json then manually copy in the params you need so it loads faster.
HardwareReport/HardwareReport.js
Outdated
|
|
||
| let have_content = false | ||
|
|
||
| // Vehicle type from build_type (determined in load_log via get_version_and_board) |
There was a problem hiding this comment.
You spotted get_version_and_board but your not using it, instead your trying to guess from params. This is very fragile. Better to use it for the base vehicle type.
There was a problem hiding this comment.
hey so the now passing build_type from
get_version_and_board()
into
load_vehicle_config()
the param based inference is only used as a fallback for .param files where no log messages are available.
There was a problem hiding this comment.
I think I would vote to just remove the param based stuff, its likely to get broken, reading from a log is the main use case.
HardwareReport/HardwareReport.js
Outdated
| if (!(option_name in params)) { | ||
| continue | ||
| } | ||
| // Check if ESC output over CAN is enabled (bit 7) |
There was a problem hiding this comment.
This is only for hobywing ESC.
HardwareReport/HardwareReport.js
Outdated
| add_cell(output.func_name) | ||
| } | ||
|
|
||
| // Check for CAN servo outputs |
There was a problem hiding this comment.
How about adding a column to the table for "DroneCAN servo" and "DroneCAN ESC", you could add a check mark or leave blank.
edengilbertus
force-pushed
the
hardware-report-vehicle-config
branch
from
0f7b939 to
403d35c
Compare
|
This is what it look like now. 
It would be nice to also convey which bus there outputting on, IE CAN 1 or 2. I wonder if doing a whole column for each output type is too much, maybe it would be better to just have a "output type" column which could have "DroneCAN ESC 0" or "DroneCAN Servo 0" in it for example. That would let us take into account the DroneCAN index offset stuff where the servo number does not match the DroneCAN index. What do you think? |
edengilbertus
force-pushed
the
hardware-report-vehicle-config
branch
from
403d35c to
f94f36f
Compare
|
hello so heres what has been done vehicle type now comes from get_version_and_board() build_type instead of guessing from params , removed HobyWing-specific bit 7 check :) |
2 participants
Display vehicle type frame class and also frame type from log parameters plus show how output pin assignments with SERVOx_FUNCTION mappings and DroneCAN ESC/Servo bitmask configuration.
Closes #242