Skip to content

parallel bitmap optimization #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
draganm merged 1 commit into from
Jan 16, 2026
+32 −4
Merged

parallel bitmap optimization #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 32 additions & 4 deletions bitmap_cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ import (
"context"
"database/sql"
"fmt"
"runtime"

"github.com/Arkiv-Network/sqlite-bitmap-store/store"
"golang.org/x/sync/errgroup"
)

type nameValue[T any] struct {
Expand Down Expand Up @@ -121,6 +123,36 @@ func (c *bitmapCache) RemoveFromNumericBitmap(ctx context.Context, name string,
}

func (c *bitmapCache) Flush(ctx context.Context) (err error) {

eg := &errgroup.Group{}

eg.SetLimit(runtime.NumCPU())

for _, bitmap := range c.stringBitmaps {
if bitmap.IsEmpty() {
continue
}
eg.Go(func() error {
bitmap.RunOptimize()
return nil
})
}

for _, bitmap := range c.numericBitmaps {
if bitmap.IsEmpty() {
continue
}
eg.Go(func() error {
bitmap.RunOptimize()
return nil
})
}

err = eg.Wait()
if err != nil {
return fmt.Errorf("failed to run optimize: %w", err)
}

for k, bitmap := range c.stringBitmaps {

if bitmap.IsEmpty() {
Expand All @@ -131,8 +163,6 @@ func (c *bitmapCache) Flush(ctx context.Context) (err error) {
continue
}

bitmap.RunOptimize()

err = c.st.UpsertStringAttributeValueBitmap(ctx, store.UpsertStringAttributeValueBitmapParams{Name: k.name, Value: k.value, Bitmap: bitmap})
if err != nil {
return fmt.Errorf("failed to upsert string attribute %q value %q bitmap: %w", k.name, k.value, err)
Expand All @@ -149,8 +179,6 @@ func (c *bitmapCache) Flush(ctx context.Context) (err error) {
continue
}

bitmap.RunOptimize()

err = c.st.UpsertNumericAttributeValueBitmap(ctx, store.UpsertNumericAttributeValueBitmapParams{Name: k.name, Value: k.value, Bitmap: bitmap})
if err != nil {
return fmt.Errorf("failed to upsert numeric attribute %q value %q bitmap: %w", k.name, k.value, err)
Expand Down