This repository was archived by the owner on Jan 11, 2024. It is now read-only.
Put inline script in a separate file#1
Open
ento wants to merge 1 commit intoAsana:masterfrom
ento:externalize-scripts
Open
Put inline script in a separate file#1ento wants to merge 1 commit intoAsana:masterfrom ento:externalize-scripts
ento wants to merge 1 commit intoAsana:masterfrom
ento:externalize-scripts
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Inline JavaScript in
background.htmlis not being executed.Cause:
This is because of the Content Security Policy adopted by Chrome's extension system. This restriction cannot be relaxed.
Fix:
This patch externalizes the JavaScript code found in
background.htmlto a file calledbackground.js.