show about.vendorName and about.vendorVersion #97
Conversation
| { label: qsTr("WLAN MAC"), text: about.wlanMacAddress }, | ||
| { label: qsTr("IMEI"), text: about.imei }, | ||
| { label: qsTr("Serial number"), text: about.serial }, | ||
| { label: qsTr("Vendor"), text: about.vendorName }, |
There was a problem hiding this comment.
Maybe "Manufacturer" and "Model" would be clearer and more concise? Not sure about that, let's ask a native @beroset
There was a problem hiding this comment.
Maybe I'm just being pedantic, but "Fossil" doesn't actually manufacture the devices with their name on them -- it's some contract manufacturing organization. That's my logic for calling it "Vendor," especially since some watches are sold under multiple "Vendor" names even though they're really manufactured in the same factory (or at least the boards are). Example: ray is sold as Misfit Vapor, Emporio Armani, Fossiq Q, Kate Spade, Michael Kors, Skagen Falster, and Tory Burch.
For that reason, I think "Vendor" is appropriate. For "Device Model" I think it's appropriate too, but I don't think it would be too confusing to change that to "Model" in this context.
There was a problem hiding this comment.
Thanks! Vendor always sounded weird to me but I'm not a native :) so let's keep vendor and use the shorter "model" then
Yep you should! :) (once we've agreed on the wording) |
Generated by command: lupdate-qt5 -no-obsolete src/* i18n/*.h -ts i18n/*.ts
|
Any reason why this is not merged yet? Lgtm. |
Yes, it depends on AsteroidOS/meta-asteroid#185 which needs updating. |
4 participants
The Settings app should show vendor name and vendor version in about dialog
In the end it should look like this
The issue is that systemsettings doesn't provide those keys in AsteroidOS. The patch allows check the actual value
AsteroidOS/meta-asteroid#185
I am not sure if I should do also the lupdate.