Skip to content

Fix create imagers#41

Closed
danjampro wants to merge 2 commits intoAstroHuntsman:developfrom
danjampro:fix_create_imagers
Closed

Fix create imagers#41
danjampro wants to merge 2 commits intoAstroHuntsman:developfrom
danjampro:fix_create_imagers

Conversation

@danjampro
Copy link
Contributor

Fixes a problem where the xrange and yrange parsed to discretize_model in the PSF code contained floating point values. This caused create_imagers to fail.


# Setup imagers
for name, imager_info in config['imagers'].items():
for name, imager_info in config['imagers'].items():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danjampro your text editor isn't stripping unnecessary white space I think?

@lspitler
Copy link
Member

@danjampro astropy have released the version which fixes this problem, so it should work now: https://github.com/astropy/astropy/releases/tag/v4.0.2 via: pip install astropy==4.0.2

My pending PR #39 includes a astropy>=4.02 requirement, so I think this PR/branch are not needed. So I'm closing this PR.

@lspitler lspitler closed this Oct 26, 2020
@wtgee
Copy link

wtgee commented Oct 26, 2020

Note that astropy >4.0.3 will currently break astroplan (astropy/astroplan#485). That will hopefully be fixed in the next day or so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants