upgrade to use Openastro package and latest versions of various packages#49
Draft
upgrade to use Openastro package and latest versions of various packages#49
Conversation
bazkiaei
approved these changes
Jan 12, 2025
bazkiaei
left a comment
bazkiaei
left a comment
There was a problem hiding this comment.
My comments contain some minor suggestions.
| "Cannot specify pixel binning with calculation type 'per arcsecond squared'!") | ||
|
|
||
| if surface_brightness: | ||
| if surface_brightness is not None: |
There was a problem hiding this comment.
Maybe when defining extended_source_signal_noise at line 311, the parameter surface_brightness should have a default value on None?
|
|
||
| if not isinstance(surface_brightness, u.Quantity): | ||
| brightness = brightness * u.ABmag | ||
| surface_brightness = surface_brightness * u.ABmag |
There was a problem hiding this comment.
Perhaps it is worth checking the unit of surface_brightness when it's a u.Quantity?
| raise ValueError("This Imager has no filter '{}'!".format(filter_name)) | ||
|
|
||
| if bool(bright_limit) == bool(shortest_exp_time): | ||
| if (bright_limit is not None and shortest_exp_time is not None) or (bright_limit is None and shortest_exp_time is None): |
There was a problem hiding this comment.
I feel the ValueError message is not for the second condition after "or".
Perhaps there should be another "if" block to raise ValueError when neither of bright_limit and shortest_exp_time are provided and have a different message that let the user know one of the two should be provided?
|
|
||
| if bool(faint_limit) == bool(num_long_exp): | ||
| raise ValueError("one and only one of faint_limit and num_long_exp must be specified!") | ||
| if (faint_limit is not None and num_long_exp is not None) or (faint_limit is None and num_long_exp is None): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.