-
Notifications
You must be signed in to change notification settings - Fork 25
Feature: Adding flag for giving starting Espers #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feature: Adding flag for giving starting Espers #34
Conversation
- this will give you between the selected range of espers from the very start
data/espers.py
Outdated
| self.available_espers = set(range(self.ESPER_COUNT)) | ||
| self.starting_espers = [] | ||
|
|
||
| if args.starting_espers_min > 0 or args.starting_espers_max <= self.ESPER_COUNT: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the second half of this or doesn't seem to accomplish much
|
I believe starting with max espers can fail with character gating. Character rewards are assigned first to ensure a path and try to make the checks (somewhat) equally likely. If characters are not randomly assigned to character/esper checks (e.g. magitek factory, FC, FT, doma wor, veldt, ...) then there will not be any remaining rewards available. I have not counted what the max number of espers can be without failing but I believe it is somewhere around 20. To increase the chances of failure, assign 4 starting characters with character gating: |
|
Thanks Atma - This crossed my mind but never followed up on it - I'm counting 7 Char/Esper only rewards, so 20 makes sense. Will do some more testing as well |
| esper_start = espers.add_mutually_exclusive_group() | ||
| esper_start.add_argument("-stesp", "--starting-espers", default = [0, 0], type = int, | ||
| nargs = 2, metavar = ("MIN", "MAX"), choices = range(MAX_STARTING_ESPERS + 1), | ||
| help = "Party starts with %(metavar) random espers") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super minor, but this shows up in -h as Party starts with ('MIN', 'MAX')andom espers.
Change %(metavar) to %(metavar)s
|
Updates merged into beta branch for &dev seeds. |
-stesp <MIN> <MAX>--starting-espers <MIN> <MAX>This flag will gives a player between MIN-MAX espers at the start of the seed
These are marked in the spoiler log similar to how we do lores: https://pastebin.com/S40YpYZ5