Skip to content

Upgrade androidx.credentials to 1.2.0-alpha05 #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aj-dt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Upgrade androidx.credentials to 1.2.0-alpha05 #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@ android {

dependencies {
implementation "androidx.lifecycle:lifecycle-viewmodel-ktx:2.6.1"
implementation "androidx.credentials:credentials:1.0.0-alpha03"
implementation "androidx.credentials:credentials:1.2.0-alpha05"

// optional - needed for credentials support from play services, for devices running
// Android 13 and below.
implementation "androidx.credentials:credentials-play-services-auth:1.0.0-alpha03"
implementation "androidx.credentials:credentials-play-services-auth:1.2.0-alpha05"
}
7 changes: 3 additions & 4 deletions android/src/main/kotlin/com/authentrend/flutter_passkey/FlutterPasskeyPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ class FlutterPasskeyPlugin: FlutterPlugin, MethodCallHandler, ActivityAware, Vie
try {
val credentialManager = CredentialManager.create(activity!!)
val result = credentialManager.createCredential(
context = activity!!,
request = createPublicKeyCredentialRequest,
activity = activity!!,
)
val credential = result as CreatePublicKeyCredentialResponse
callback(credential.registrationResponseJson, null)
Expand All @@ -66,15 +66,14 @@ class FlutterPasskeyPlugin: FlutterPlugin, MethodCallHandler, ActivityAware, Vie
}
JSONObject(options) // check if options is a valid json string
val getPublicKeyCredentialOption = GetPublicKeyCredentialOption(
requestJson = options,
preferImmediatelyAvailableCredentials = false
requestJson = options
)
viewModelScope.launch {
try {
val credentialManager = CredentialManager.create(activity!!)
val result = credentialManager.getCredential(
context = activity!!,
request = GetCredentialRequest(listOf(getPublicKeyCredentialOption)),
activity = activity!!,
)
val credential = result.credential as PublicKeyCredential
callback(credential.authenticationResponseJson, null)
Expand Down