Changing order of operations in _sanitize_field_value#113
Open
tmtrademark wants to merge 2 commits intoAutomattic:mainfrom
Open
Changing order of operations in _sanitize_field_value#113tmtrademark wants to merge 2 commits intoAutomattic:mainfrom
tmtrademark wants to merge 2 commits intoAutomattic:mainfrom
Conversation
…tize callback can be executed before date conversion happens
Member
|
Probably better to fix the strtotime conversion; have it handle an array input? |
Author
|
@mjangda Now handles array input |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Locally, I made the datepicker field cloneable, but _sanitize_field_value chokes when strtotime() is fed an Array of values. Switching the order of sanitize_callback allows for customized sanitization of these values.